Changes between Initial Version and Version 5 of Ticket #21613
- Timestamp:
- 09/30/16 10:12:43 (6 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #21613
- Property Cc mkoeppe jdemeyer added
-
Ticket #21613 – Description
initial v5 5 5 The appropriate time to do this would be either just before the `build_py` command is run, or the `build_ext` command is run (in the case of autogenerated sources for extension modules). 6 6 7 In the current cases we have its very trivial to check whether or not any of the sources actually need to be regenerated, and this is a pretty normal thing to do in some other complex Python packages. For example, the package responsible for generating the source files (e.g. currently the `sage_setup.autogen` sub-packages) simply needs to be responsible for knowing what its own source code files are, and knowing the paths for its generated sources--then just compare modtimes. 7 In the current cases we have its very trivial to check whether or not any of the sources actually need to be regenerated, and this is a pretty normal thing to do in some other complex Python packages. For example, the package responsible for generating the source files (e.g. currently the `sage_setup.autogen` sub-packages) simply needs to be responsible for knowing what its own source code files are, and knowing the paths for its generated sources--then just compare modtimes. Invoking make is not required at all. 8 8 9 9 One can do even better by having one of the generated files be a hash of the source files, and compare the hashes instead (this avoids rebuilds when switching between git branches but where the files didn't otherwise change).