Opened 6 years ago
Closed 6 years ago
#21608 closed defect (fixed)
Univariate Polynomial Ring does not support lc, lm, lt
Reported by:  David Haley  Owned by:  

Priority:  major  Milestone:  sage7.5 
Component:  commutative algebra  Keywords:  ucdmat1652016 
Cc:  Matthias Köppe, Yuan Zhou, Travis Scrimshaw, Dima Pasechnik  Merged in:  
Authors:  Yuan Zhou  Reviewers:  Matthias Koeppe 
Report Upstream:  N/A  Work issues:  
Branch:  96efafe (Commits, GitHub, GitLab)  Commit:  96efafee6344a657047df8b2d117c34b162d4dcc 
Dependencies:  Stopgaps: 
Description (last modified by )
The following useful methods
lc
, lm
, lt
, monomial_coefficient
, monomials
and gradient
are defined for multivariate polynomial rings,
but are missing (or having different names) for univariate polynomial rings.
Change History (12)
comment:1 Changed 6 years ago by
Cc:  Matthias Köppe added 

Keywords:  ucdmat1652016 added 
Priority:  minor → major 
comment:2 Changed 6 years ago by
Cc:  Yuan Zhou added 

Description:  modified (diff) 
comment:3 Changed 6 years ago by
Description:  modified (diff) 

comment:4 Changed 6 years ago by
Description:  modified (diff) 

comment:5 Changed 6 years ago by
Branch:  → u/yzh/univariate_polynomial_ring_does_not_support_lc__lm__lt 

comment:6 Changed 6 years ago by
Authors:  → Yuan Zhou 

Commit:  → a7fcd0ac8cdbe8c6f2bd6034e4acee4fed3ea892 
Status:  new → needs_review 
comment:7 Changed 6 years ago by
Status:  needs_review → needs_work 

Docstring of gradient
should be clarified  there's only 1 partial derivative.
Docstring of lm
is wrong.
comment:8 Changed 6 years ago by
Commit:  a7fcd0ac8cdbe8c6f2bd6034e4acee4fed3ea892 → 96efafee6344a657047df8b2d117c34b162d4dcc 

Branch pushed to git repo; I updated commit sha1. New commits:
96efafe  fix errors in docstrings

comment:9 Changed 6 years ago by
Cc:  Travis Scrimshaw Dima Pasechnik added 

Status:  needs_work → needs_review 
comment:10 Changed 6 years ago by
This looks good to me. But since the new methodlc
is now a duplicate of leading_coefficient
in univariate polynomial rings (to be compatible with multivariate polynomial rings' method lc
, I'm wondering if:
leading_coefficient
should be deprecated or also the alias
leading_coefficient
should be supplied for the multivariate case.
comment:11 Changed 6 years ago by
Milestone:  sage7.4 → sage7.5 

Reviewers:  → Matthias Koeppe 
Status:  needs_review → positive_review 
comment:12 Changed 6 years ago by
Branch:  u/yzh/univariate_polynomial_ring_does_not_support_lc__lm__lt → 96efafee6344a657047df8b2d117c34b162d4dcc 

Resolution:  → fixed 
Status:  positive_review → closed 
Note: See
TracTickets for help on using
tickets.
The method
coefficient
doesn't make much sense for univariate polynomials. One would rather usemonomial_coefficient
.