Opened 6 years ago

Closed 6 years ago

#21605 closed defect (wontfix)

Workaround for failing complex_double test on Cygwin

Reported by: Erik Bray Owned by:
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: porting: Cygwin Keywords:
Cc: Merged in:
Authors: Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: u/embray/bug/cygwin/complex_double_test (Commits, GitHub, GitLab) Commit: 77feef03b7ab487a0025a19e5b164e727d7aeb9b
Dependencies: Stopgaps:

Status badges

Description (last modified by Erik Bray)

I fixed this a while ago, but realized I don't think I ever made a ticket for it.

This test fails due to minor numerical differences (again, probably originating in the log() function) so that the polynomial returned by z.algdep(5) ends up being slightly different (it gets an extra factor of x^2). This makes the test a little more flexible to such differences.

Change History (7)

comment:1 Changed 6 years ago by Erik Bray

Dependencies: #21292
Description: modified (diff)
Milestone: sage-7.4sage-8.0
Status: newneeds_review

#21292 remains stalled, but this simple test fix doesn't require it; better to just fix this.

comment:2 Changed 6 years ago by Jeroen Demeyer

#22759 solves the same problem in a different (arguably better) way.

comment:3 Changed 6 years ago by Erik Bray

Oh, that's new--I'll have a look.

comment:4 Changed 6 years ago by Erik Bray

I see now--this should fix the underlying problem I think, but I'll have to test it.

comment:5 Changed 6 years ago by Travis Scrimshaw

Milestone: sage-8.0sage-duplicate/invalid/wontfix

Since #22759, I think we can close this as a dup.

comment:6 Changed 6 years ago by Jeroen Demeyer

Authors: Erik Bray
Reviewers: Erik Bray
Status: needs_reviewpositive_review

comment:7 Changed 6 years ago by Erik Bray

Resolution: wontfix
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.