Opened 3 years ago

Closed 3 years ago

#21603 closed enhancement (fixed)

Update GCC to 5.4.0

Reported by: jpflori Owned by:
Priority: major Milestone: sage-7.5
Component: packages: standard Keywords:
Cc: leif, fbissey, jdemeyer, vbraun Merged in:
Authors: Jean-Pierre Flori Reviewers: Jeroen Demeyer, Ralf Stephan
Report Upstream: N/A Work issues:
Branch: 62d5fc8 (Commits) Commit: 62d5fc85b465e89955572c107e9b218d47d45fdc
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

We currently ship 4.9.3 which is quite old.

Tarball: ftp://ftp.uvsq.fr/pub/gcc/releases/gcc-5.4.0/gcc-5.4.0.tar.bz2

Change History (22)

comment:1 Changed 3 years ago by jdemeyer

Which version do you have in mind?

comment:2 follow-ups: Changed 3 years ago by jpflori

Would 6.2 be too adventurous?

comment:3 in reply to: ↑ 2 Changed 3 years ago by jdemeyer

Replying to jpflori:

Would 6.2 be too adventurous?

There is only one way to find out :-)

comment:4 Changed 3 years ago by jpflori

  • Authors set to Jean-Pierre Flori
  • Branch set to public/gcc62
  • Commit set to 9922faa9e3b57634e2533b518225b6ed3808650f
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

9922faaUpdate GCC to 6.2.

comment:5 Changed 3 years ago by jpflori

  • Summary changed from Update GCC to Update GCC to 6.2.0

comment:6 in reply to: ↑ 2 Changed 3 years ago by leif

Replying to jpflori:

Would 6.2 be too adventurous?

See also #20350.

comment:7 Changed 3 years ago by leif

4.9.4 is out since a while, too, by the way. ;-)

comment:8 Changed 3 years ago by jdemeyer

  • Milestone changed from sage-7.4 to sage-7.5
  • Reviewers set to Jeroen Demeyer

Works for me.

comment:9 Changed 3 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:10 Changed 3 years ago by jhpalmieri

On OS X Sierra, this works if I merge #21567. If I merge instead with the 7.5.beta0 branch, it doesn't:

***************************************************************
Error building Sage.

The following package(s) may have failed to build (not necessarily
during this run of 'make all'):

* package: libfplll-5.0.3rc0

Here is the tail end of the (serial) build log for libfplll:

libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I.. -DFPLLL_DEFAULT_STRATEGY_PATH=\"/Users/palmieri/Desktop/TESTING/sage-7.5.beta0/local/share/fplll/strategies\" -DFPLLL_DEFAULT_STRATEGY=\"/Users/palmieri/Desktop/TESTING/sage-7.5.beta0/local/share/fplll/strategies/default.json\" -I./.. -I/Users/palmieri/Desktop/TESTING/sage-7.5.beta0/local/include/ -fPIC -I/Users/palmieri/Desktop/TESTING/sage-7.5.beta0/local/include/ -L/Users/palmieri/Desktop/TESTING/sage-7.5.beta0/local/lib -O3 -MT gso.lo -MD -MP -MF .deps/gso.Tpo -c gso.cpp -o gso.o >/dev/null 2>&1
depbase=`echo pruner.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\
	/bin/sh ../libtool  --tag=CXX   --mode=compile g++ -DHAVE_CONFIG_H -I. -I..  -DFPLLL_DEFAULT_STRATEGY_PATH=\"/Users/palmieri/Desktop/TESTING/sage-7.5.beta0/local/share/fplll/strategies\" -DFPLLL_DEFAULT_STRATEGY=\"/Users/palmieri/Desktop/TESTING/sage-7.5.beta0/local/share/fplll/strategies/default.json\" -I./.. -I/Users/palmieri/Desktop/TESTING/sage-7.5.beta0/local/include/  -fPIC -I/Users/palmieri/Desktop/TESTING/sage-7.5.beta0/local/include/ -L/Users/palmieri/Desktop/TESTING/sage-7.5.beta0/local/lib -O3 -MT pruner.lo -MD -MP -MF $depbase.Tpo -c -o pruner.lo pruner.cpp &&\
	mv -f $depbase.Tpo $depbase.Plo
libtool: compile:  g++ -DHAVE_CONFIG_H -I. -I.. -DFPLLL_DEFAULT_STRATEGY_PATH=\"/Users/palmieri/Desktop/TESTING/sage-7.5.beta0/local/share/fplll/strategies\" -DFPLLL_DEFAULT_STRATEGY=\"/Users/palmieri/Desktop/TESTING/sage-7.5.beta0/local/share/fplll/strategies/default.json\" -I./.. -I/Users/palmieri/Desktop/TESTING/sage-7.5.beta0/local/include/ -fPIC -I/Users/palmieri/Desktop/TESTING/sage-7.5.beta0/local/include/ -L/Users/palmieri/Desktop/TESTING/sage-7.5.beta0/local/lib -O3 -MT pruner.lo -MD -MP -MF .deps/pruner.Tpo -c pruner.cpp  -fno-common -DPIC -o .libs/pruner.o
pruner.cpp: In member function 'FT fplll::Pruner<FT>::single_enum_cost(const evec&) [with FT = fplll::FP_NR<long double>]':
pruner.cpp:306:31: internal compiler error: Segmentation fault: 11
 template <class FT> inline FT Pruner<FT>::single_enum_cost(/*i*/ const evec &b)
                               ^~~~~~~~~~

pruner.cpp:306:31: internal compiler error: Abort trap: 6
g++: internal compiler error: Abort trap: 6 (program cc1plus)
Please submit a full bug report,
with preprocessed source if appropriate.
See <http://gcc.gnu.org/bugs.html> for instructions.
make[5]: *** [pruner.lo] Error 1
make[4]: *** [all] Error 2
make[3]: *** [all-recursive] Error 1
make[2]: *** [all] Error 2
Error building fplll
Last edited 3 years ago by jhpalmieri (previous) (diff)

comment:11 Changed 3 years ago by jhpalmieri

  • Status changed from positive_review to needs_work

Same happens with 7.5.beta1. I'm going to set this to "needs work", but feel free to change it back if I've missed something.

comment:12 Changed 3 years ago by jdemeyer

Given that we all seem to agree that upgrading GCC is a good thing to do, should we try GCC 5.4 instead?

comment:13 follow-up: Changed 3 years ago by fbissey

Hum... I am not sure what differences between 7.4 and 7.5.beta0 could cause this. On the other hand I would try to upgrade fplll to 5.0.3, there are a few QA fix that I think may just be related.

comment:14 Changed 3 years ago by rws

If this works with #21567 is there a need to change the gcc version? Just depend on #21567.

comment:15 in reply to: ↑ 13 Changed 3 years ago by jhpalmieri

Replying to fbissey:

Hum... I am not sure what differences between 7.4 and 7.5.beta0 could cause this. On the other hand I would try to upgrade fplll to 5.0.3, there are a few QA fix that I think may just be related.

If you can provide a tarball for a different version of fplll, I am happy to test it.

comment:16 Changed 3 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Update GCC to 6.2.0 to Update GCC to 5.4.0

comment:17 Changed 3 years ago by git

  • Commit changed from 9922faa9e3b57634e2533b518225b6ed3808650f to 62d5fc85b465e89955572c107e9b218d47d45fdc

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

62d5fc8Update GCC to 5.4.0

comment:18 Changed 3 years ago by jdemeyer

  • Status changed from needs_work to needs_review

comment:19 Changed 3 years ago by jhpalmieri

Now everything builds for me.

comment:20 Changed 3 years ago by jhpalmieri

So if it's okay with everyone else to use GCC 5.4.0 instead of 6.2.0, positive review.

comment:21 Changed 3 years ago by rws

  • Reviewers changed from Jeroen Demeyer to Jeroen Demeyer, Ralf Stephan
  • Status changed from needs_review to positive_review

Fine with me.

comment:22 Changed 3 years ago by vbraun

  • Branch changed from public/gcc62 to 62d5fc85b465e89955572c107e9b218d47d45fdc
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.