Opened 4 years ago

Closed 4 years ago

#21602 closed enhancement (fixed)

LatticePoset: certificate for is_supersolvable()

Reported by: jmantysalo Owned by:
Priority: major Milestone: sage-7.4
Component: combinatorics Keywords:
Cc: chapoton Merged in:
Authors: Jori Mäntysalo Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 723be03 (Commits) Commit: 723be03bb27962e2a1bd1b31e71c96f913841a61
Dependencies: Stopgaps:

Description

This patch will add an option to get a M-chain (as called in EC) from is_supersolvable().

Change History (6)

comment:1 Changed 4 years ago by jmantysalo

  • Branch set to u/jmantysalo/supersolvable-cert

comment:2 Changed 4 years ago by jmantysalo

  • Commit set to 723be03bb27962e2a1bd1b31e71c96f913841a61
  • Status changed from new to needs_review

New commits:

723be03Add certificate to is_supersolvable.

comment:3 follow-up: Changed 4 years ago by tscrim

Did you run timings? I'm very slightly worried about the extra push/pop operations in a second list. I doubt it will be much of anything, but I'm allowed some slight paranoia I hope. :P

comment:4 in reply to: ↑ 3 Changed 4 years ago by jmantysalo

Replying to tscrim:

Did you run timings?

No, I did not. But now I tested with list of all 12-element lattices. There are 262776 of those, and 2761 are supersolvable. It takes less with this patch to compute (i.e. the time is too short to measure), slightly below 25 seconds. I also tested with chain of 500 elements and got similar results.

Paranoia is a good thing.

comment:5 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

That will work; positive review.

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/jmantysalo/supersolvable-cert to 723be03bb27962e2a1bd1b31e71c96f913841a61
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.