Opened 3 years ago

Closed 3 years ago

#21601 closed enhancement (fixed)

Add canonical meetands

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-7.5
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: Jori Mäntysalo Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: cb7b710 (Commits) Commit: cb7b7101a5bb41f76fb059f7d620b1ef3545504f
Dependencies: Stopgaps:

Description

For symmetry with #21597 after that has been closed.

Change History (4)

comment:1 Changed 3 years ago by jmantysalo

  • Branch set to u/jmantysalo/add_canonical_meetands

comment:2 Changed 3 years ago by jmantysalo

  • Cc tscrim added
  • Commit set to cb7b7101a5bb41f76fb059f7d620b1ef3545504f
  • Milestone changed from sage-7.4 to sage-7.5
  • Status changed from new to needs_review

Done this. The code is just a direct dual. To test try 

n = 30; seed = 42; p = 0.999
set_random_seed(seed)
L = Posets.RandomLattice(n, p)
L_ = L.dual()
for e in L:
    if L.canonical_joinands(e) is None and L_.canonical_meetands(e) is None:
        continue
    if sorted(L.canonical_joinands(e)) != sorted(L_.canonical_meetands(e)):
        print("ERROR")
        break
else:
    print("OK")

New commits:

​cb7b710Add canonical meetands.

comment:3 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/jmantysalo/add_canonical_meetands to cb7b7101a5bb41f76fb059f7d620b1ef3545504f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.