Changes between Version 1 and Version 26 of Ticket #21598


Ignore:
Timestamp:
04/14/17 08:58:44 (5 years ago)
Author:
embray
Comment:

I updated the description with a link to my pull request. In short, I have submitted this patch as proof of concept, but I acknowledged in doing so that it's not ready. The code works though, it just needs refactoring. For the purposes of patching psutil in Sage it's fine though.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #21598

    • Property Status changed from new to needs_review
    • Property Authors changed from to Erik Bray
    • Property Milestone changed from sage-7.4 to sage-8.0
    • Property Dependencies changed from to #22625
    • Property Branch changed from to u/embray/cygwin/psutil-support
    • Property Report Upstream changed from N/A to Reported upstream. Developers acknowledge bug.
    • Property Owner changed from (none) to embray
    • Property Commit changed from to bac432890b5aedca346cdeb7374b95b3fe27daf8

  • Ticket #21598 – Description

    v1 v26  
    11Installing psutil on cygwin simply doesn't work.  It actually refuses to install on cygwin.  See attached log.
    22
    3 The relevant issue for psutil is here: https://github.com/giampaolo/psutil/issues/82  It was determined unfixable due mainly to lack of time / expertise.  I at least suspect I can get something working.
     3The relevant upstream issue for psutil is here: https://github.com/giampaolo/psutil/issues/82
     4
     5My in-progress pull request is here: https://github.com/giampaolo/psutil/pull/998
     6
     7The attached patch is based on the current version of my pull request, where all (relevant) tests pass on Cygwin.  The code itself is a bit of a mess and needs refactoring, so it will take a little more time before I can get this accepted upstream.  But in the meantime I will maintain this patch for Sage.