Opened 6 years ago

Closed 6 years ago

#21597 closed enhancement (fixed)

Add a function to get the canonical joinands of an element of a lattice

Reported by: jmantysalo Owned by:
Priority: major Milestone: sage-7.4
Component: combinatorics Keywords:
Cc: Merged in:
Authors: Jori Mäntysalo Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 1b5045e (Commits, GitHub, GitLab) Commit: 1b5045eb15cf8c9ec1bc85b3fd2f21066949dcc5
Dependencies: Stopgaps:

Status badges

Description

Add a function to get the canonical joinands of a lattice element.

Change History (7)

comment:1 Changed 6 years ago by jmantysalo

  • Branch set to u/jmantysalo/canonical-joinands

comment:2 Changed 6 years ago by jmantysalo

  • Commit set to c9aa76087eb541f2561763ee3df986554bad1185
  • Status changed from new to needs_review

New commits:

​c9aa760Add canonical_joinands().

comment:3 follow-up: Changed 6 years ago by tscrim

You should include a test where it does not exist. Also, to be Python3 compatible, change iter.next() to next(iter).

comment:4 Changed 6 years ago by git

  • Commit changed from c9aa76087eb541f2561763ee3df986554bad1185 to 1b5045eb15cf8c9ec1bc85b3fd2f21066949dcc5

Branch pushed to git repo; I updated commit sha1. New commits:

​1b5045ePy3-style next.

comment:5 in reply to: ↑ 3 ; follow-up: Changed 6 years ago by jmantysalo

Replying to tscrim:

You should include a test where it does not exist.

There is one already: L.canonical_joinands(6) is None.

Also, to be Python3 compatible, change iter.next() to next(iter).

Done.

comment:6 in reply to: ↑ 5 Changed 6 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Replying to jmantysalo:

Replying to tscrim:

You should include a test where it does not exist.

There is one already: L.canonical_joinands(6) is None.

Whoops, missed that.

Positive review.

comment:7 Changed 6 years ago by vbraun

  • Branch changed from u/jmantysalo/canonical-joinands to 1b5045eb15cf8c9ec1bc85b3fd2f21066949dcc5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.