Opened 4 years ago
Closed 4 years ago
#21572 closed enhancement (fixed)
Simplify qhull spkg patch
Reported by:  mkoeppe  Owned by:  

Priority:  major  Milestone:  sage7.4 
Component:  packages: optional  Keywords:  
Cc:  vdelecroix, jdemeyer, dimpase  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  Jeroen Demeyer 
Report Upstream:  N/A  Work issues:  
Branch:  808f960 (Commits)  Commit:  808f96024896b7c40657702e2c663288bce199db 
Dependencies:  Stopgaps: 
Description (last modified by )
This is for #21534.
The ticket also changes "make j1" to "$MAKE".
The "j1" should be unnecessary. The Makefile.patch
purports to fix the dependency problems of the original Makefile; and a parallel build works for me with it.
Change History (11)
comment:1 Changed 4 years ago by
 Branch set to u/mkoeppe/simplify_qhull_spkg_patch_and_use_sage_local_instead_of_sage_root_local
comment:2 Changed 4 years ago by
 Cc jdemeyer added
 Commit set to ac49e35f36d33e13266a27489621578291736191
 Description modified (diff)
 Status changed from new to needs_review
comment:3 Changed 4 years ago by
 Cc dimpase added
comment:4 Changed 4 years ago by
 Reviewers set to Jeroen Demeyer
 Summary changed from Simplify qhull spkg patch and use SAGE_LOCAL instead of SAGE_ROOT/local to Simplify qhull spkg patch
comment:5 Changed 4 years ago by
 Branch changed from u/mkoeppe/simplify_qhull_spkg_patch_and_use_sage_local_instead_of_sage_root_local to u/jdemeyer/simplify_qhull_spkg_patch_and_use_sage_local_instead_of_sage_root_local
comment:6 Changed 4 years ago by
 Commit changed from ac49e35f36d33e13266a27489621578291736191 to 30bf5d5d72a2b73819a41337b7fd8fa814320972
comment:7 Changed 4 years ago by
I do get failures with a parallel build:
============================================ == make qtest ============================== ============================================ == Otherwise if user_eg fails to link, switch to lqhullstatic_r bin/qconvex == Sun Sep 25 09:26:10 CEST 2016 ============================================ QH6075 == Test nonreentrant qset.c with mem.c ==== qhull input error: short input file. Did not find dimension and number of points While executing:  qconvex Options selected for Qhull 2015.2 2016/01/18: runid 511880916 Makefile:323: recipe for target 'qconvexprompt' failed make: *** [qconvexprompt] Error 1 make: *** Waiting for unfinished jobs....
comment:8 Changed 4 years ago by
 Commit changed from 30bf5d5d72a2b73819a41337b7fd8fa814320972 to 808f96024896b7c40657702e2c663288bce199db
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
808f960  Use $MAKE instead of make

comment:9 Changed 4 years ago by
Put back the j1
option. Please check and then set this to positive_review if you agree.
comment:10 Changed 4 years ago by
 Status changed from needs_review to positive_review
Thanks for testing this thoroughly.
comment:11 Changed 4 years ago by
 Branch changed from u/jdemeyer/simplify_qhull_spkg_patch_and_use_sage_local_instead_of_sage_root_local to 808f96024896b7c40657702e2c663288bce199db
 Resolution set to fixed
 Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
Don't patch DESTDIR in Makefile, just pass it as an argument
Use make j8, remove j1 for building