Opened 6 years ago

Closed 21 months ago

#21569 closed enhancement (duplicate)

Install src/bin/* scripts via setup.py (scripts, console_scripts)

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: build Keywords:
Cc: was, vbraun, jdemeyer, embray, fbissey, leif, thansen, saraedum, dimpase, isuruf, chapoton Merged in:
Authors: Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by mkoeppe)

Currently the scripts in src/bin are installed by build/make/Makefile.

As part of #21507, for those scripts that should be considered part of sagelib, the installation should be done by src/setup.py instead, using the ​scripts and console-scripts features.

(Example, ​received from was: ​​https://github.com/sagemathinc/smc/tree/master/src/smc_pyutil. See, in particular, the console_scripts section of setup.py: ​​https://github.com/sagemathinc/smc/blob/master/src/smc_pyutil/setup.py#L58)

(Those scripts that don't belong into src/bin are moved to build/bin by #21559. See also: #21570: Move non-scripts of src/bin/ elsewhere (and also move their install location; #21707: Split sage-env into sage-build-env and sage-env)

Change History (13)

comment:1 Changed 6 years ago by mkoeppe

  • Description modified (diff)

comment:2 Changed 6 years ago by mkoeppe

  • Type changed from PLEASE CHANGE to enhancement

comment:3 Changed 6 years ago by mkoeppe

  • Description modified (diff)

comment:4 Changed 6 years ago by embray

+1

comment:5 Changed 6 years ago by mkoeppe

Erik, Jeroen - should this be done on top of #21604 and #21600; or does it have to wait for other tickets?

comment:6 Changed 6 years ago by embray

Normally this shouldn't be dependent on those tickets, and I can't think of any reason it would be. But I've come not to expect normalcy with sage.

comment:7 Changed 6 years ago by mkoeppe

  • Description modified (diff)

comment:8 Changed 4 years ago by mkoeppe

  • Cc thansen saraedum added

In #22731 comment 28, it is proposed to move scripts to $SAGE_LOCAL/libexec. Could a setuptools expert comment whether setup.sh would be able to do this, or can it only install into bin (via the scripts and console_scripts features)?

comment:9 Changed 2 years ago by mkoeppe

  • Cc dimpase isuruf added
  • Milestone changed from sage-7.4 to sage-9.1

comment:10 Changed 2 years ago by mkoeppe

  • Milestone changed from sage-9.1 to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

I'm taking care of this task in #21559. The present ticket can be closed as a duplicate.

comment:11 Changed 2 years ago by mkoeppe

  • Cc chapoton added

comment:12 Changed 2 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

comment:13 Changed 21 months ago by slelievre

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.