Opened 6 years ago
Closed 6 years ago
#21568 closed enhancement (fixed)
py3 use py3 compatible syntax for zip in doctests
Reported by: | Frédéric Chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.4 |
Component: | python3 | Keywords: | |
Cc: | Merged in: | ||
Authors: | Frédéric Chapoton | Reviewers: | Jori Mäntysalo |
Report Upstream: | N/A | Work issues: | |
Branch: | 8fd6531 (Commits, GitHub, GitLab) | Commit: | 8fd653101e349eeef98bdd37236a8a9bc915de98 |
Dependencies: | Stopgaps: |
Description
wrapping with list where necessary
part of #16082
Change History (7)
comment:1 Changed 6 years ago by
Branch: | → u/chapoton/21568 |
---|---|
Commit: | → a571da72eda47e7679b8a10a285b03ca0336f70a |
Status: | new → needs_review |
comment:2 Changed 6 years ago by
Reviewers: | → Jori Mäntysalo |
---|---|
Status: | needs_review → needs_work |
Does not work, because there is a line list = []
in src/sage/plot/plot3d/implicit_surface.pyx
.
comment:3 Changed 6 years ago by
Btw, list=[1,2,3,4,5]
on src/sage/misc/functional.py
should be changed too. Found by
egrep 'sage:.+[^a-z_0-9A-Z.]list ?=' src/sage -R
comment:4 Changed 6 years ago by
Commit: | a571da72eda47e7679b8a10a285b03ca0336f70a → 8fd653101e349eeef98bdd37236a8a9bc915de98 |
---|
Branch pushed to git repo; I updated commit sha1. New commits:
8fd6531 | trac 21568 do not overwrite the reserved word "list"
|
comment:6 Changed 6 years ago by
Status: | needs_work → positive_review |
---|
Replying to chapoton:
Done. Thank you, Jori, for all your helpful work.
You have done much more, so thanks to you.
Works now. I suppose you forgot to mark this as needs review, and mark this as positive review.
comment:7 Changed 6 years ago by
Branch: | u/chapoton/21568 → 8fd653101e349eeef98bdd37236a8a9bc915de98 |
---|---|
Resolution: | → fixed |
Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
futurize some zips in the doctests