Opened 6 years ago

Closed 6 years ago

#21568 closed enhancement (fixed)

py3 use py3 compatible syntax for zip in doctests

Reported by: Frédéric Chapoton Owned by:
Priority: major Milestone: sage-7.4
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: 8fd6531 (Commits, GitHub, GitLab) Commit: 8fd653101e349eeef98bdd37236a8a9bc915de98
Dependencies: Stopgaps:

Status badges

Description

wrapping with list where necessary

part of #16082

Change History (7)

comment:1 Changed 6 years ago by Frédéric Chapoton

Branch: u/chapoton/21568
Commit: a571da72eda47e7679b8a10a285b03ca0336f70a
Status: newneeds_review

New commits:

a571da7futurize some zips in the doctests

comment:2 Changed 6 years ago by Jori Mäntysalo

Reviewers: Jori Mäntysalo
Status: needs_reviewneeds_work

Does not work, because there is a line list = [] in src/sage/plot/plot3d/implicit_surface.pyx.

comment:3 Changed 6 years ago by Jori Mäntysalo

Btw, list=[1,2,3,4,5] on src/sage/misc/functional.py should be changed too. Found by

egrep 'sage:.+[^a-z_0-9A-Z.]list ?=' src/sage -R

comment:4 Changed 6 years ago by git

Commit: a571da72eda47e7679b8a10a285b03ca0336f70a8fd653101e349eeef98bdd37236a8a9bc915de98

Branch pushed to git repo; I updated commit sha1. New commits:

8fd6531trac 21568 do not overwrite the reserved word "list"

comment:5 Changed 6 years ago by Frédéric Chapoton

Done. Thank you, Jori, for all your helpful work.

comment:6 in reply to:  5 Changed 6 years ago by Jori Mäntysalo

Status: needs_workpositive_review

Replying to chapoton:

Done. Thank you, Jori, for all your helpful work.

You have done much more, so thanks to you.

Works now. I suppose you forgot to mark this as needs review, and mark this as positive review.

comment:7 Changed 6 years ago by Volker Braun

Branch: u/chapoton/215688fd653101e349eeef98bdd37236a8a9bc915de98
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.