Opened 3 years ago
Closed 3 years ago
#21568 closed enhancement (fixed)
py3 use py3 compatible syntax for zip in doctests
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.4 |
Component: | python3 | Keywords: | |
Cc: | Merged in: | ||
Authors: | Frédéric Chapoton | Reviewers: | Jori Mäntysalo |
Report Upstream: | N/A | Work issues: | |
Branch: | 8fd6531 (Commits) | Commit: | 8fd653101e349eeef98bdd37236a8a9bc915de98 |
Dependencies: | Stopgaps: |
Description
wrapping with list where necessary
part of #16082
Change History (7)
comment:1 Changed 3 years ago by
- Branch set to u/chapoton/21568
- Commit set to a571da72eda47e7679b8a10a285b03ca0336f70a
- Status changed from new to needs_review
comment:2 Changed 3 years ago by
- Reviewers set to Jori Mäntysalo
- Status changed from needs_review to needs_work
Does not work, because there is a line list = []
in src/sage/plot/plot3d/implicit_surface.pyx
.
comment:3 Changed 3 years ago by
Btw, list=[1,2,3,4,5]
on src/sage/misc/functional.py
should be changed too. Found by
egrep 'sage:.+[^a-z_0-9A-Z.]list ?=' src/sage -R
comment:4 Changed 3 years ago by
- Commit changed from a571da72eda47e7679b8a10a285b03ca0336f70a to 8fd653101e349eeef98bdd37236a8a9bc915de98
Branch pushed to git repo; I updated commit sha1. New commits:
8fd6531 | trac 21568 do not overwrite the reserved word "list"
|
comment:5 follow-up: ↓ 6 Changed 3 years ago by
Done. Thank you, Jori, for all your helpful work.
comment:6 in reply to: ↑ 5 Changed 3 years ago by
- Status changed from needs_work to positive_review
Replying to chapoton:
Done. Thank you, Jori, for all your helpful work.
You have done much more, so thanks to you.
Works now. I suppose you forgot to mark this as needs review, and mark this as positive review.
comment:7 Changed 3 years ago by
- Branch changed from u/chapoton/21568 to 8fd653101e349eeef98bdd37236a8a9bc915de98
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
futurize some zips in the doctests