Move sage-the-distribution scripts from src/bin to build/bin; install remaining src/bin scripts by setup.py, not make

[mkoeppe]

This ticket cleans up src/bin and how its contents are installed. One of its goals is to make the sagelib installation done by src/setup.py self-contained regarding the scripts that it needs at runtime.

Move to build/bin (no longer installed in SAGE_LOCAL):

# Used only by some build/pkgs/SPKG/spkg-install scripts, not by anything in src
testcc.sh
testcflags.sh
testcxx.sh
# Only used by build/make/deps
sage-starts                    

Obsolete, delete:

sage-README-osx.txt      # see #25995, #21570
sage-pkg       # a script to create old-style spkgs
sage-unzip   # unused

Install by a script package sage-distribution-scripts? These would be scripts that only sage-the-distribution would install in SAGE_LOCAL, but would not be in OS packages:

sage-list-experimental
sage-list-optional
sage-list-packages
sage-list-standard

Left in src/bin, installation changed to be done by src/setup.py using the scripts feature, instead of by build/make/Makefile (after scanning them in configure) (this used to be ticket #21569). All of these scripts must be useful in OS packaging of sagelib as well:

sage
sage-eval       #??

Helper scripts that have no business of being in the user's PATH. They belong to something like libexec. Perhaps src/sage/ext_data/libexec?

sage-version.sh

In follow-up tickets, src/bin could be cleaned up more. See the list of files added on this ticket to src/setup.py.

Not an executable script, move elsewhere (#21570):

To be determined (see list):

math-readline
sage-cleaner
sage-clone-source
sage-coverage
sage-coverageall
sage-cython
sage-download-upstream                 # -> build?
sage-env
sage-env-config
sage-env-config.in
sage-fix-pkg-checksums               # -> build?
sage-fixdoctests
sage-gdb-commands
sage-grep
sage-grepdoc
sage-inline-fortran
sage-ipynb2rst
sage-ipython
sage-location
sage-maxima.lisp
sage-native-execute
sage-notebook
sage-num-threads.py
sage-open
sage-preparse
sage-pypkg-location
sage-python
sage-rebase.bat
sage-rebase.sh
sage-rebaseall.bat
sage-rebaseall.sh
sage-rst2sws
sage-rst2txt
sage-rsyncdist
sage-run
sage-run-cython
sage-runtests
sage-sdist
sage-startuptime.py
sage-sws2rst
sage-update-src
sage-update-version
sage-upgrade

(Based on the full list of src/bin as of 9.1.beta4.)

See also

• #21707: Split sage-env into sage-build-env and sage-env

[embray]

+1

Also sage-pip-install of #21441, but I might wait until that ticket is merged first, then move that script along with the others.

[jdemeyer]

Replying to embray:

+1

Also sage-pip-install of #21441

I already moved that in #21441 (which still needs review by the way).

[vdelecroix]

update milestone 8.3 -> 8.4

[embray]

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

[mkoeppe]

New commits:

​1a54a80	Move src/bin/testc*.sh to build/bin/, delete src/bin/sage-README-osx.txt
​428ea11	Install src/bin/* by setup.py [scripts] instead of by build/make/deps

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​1b3c860

Move src/bin/sage-starts to build/bin/

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​546d1b0

Merge tag '9.1.beta7' into t/21559/change-src-bin-installation

[mkoeppe]

This ticket could use some help from distribution packagers...

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​2850b50	Move src/bin/testc*.sh to build/bin/, delete src/bin/sage-README-osx.txt
​4466fd6	Install src/bin/* by setup.py [scripts] instead of by build/make/deps
​26b7596	Move src/bin/sage-starts to build/bin/
​dddd462	Remove obsolete script sage-pkg (creates old-style spkg archives)

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​9825799

src/bin/sage-unzip: Remove (unused script)

[arojas]

This breaks if you try to install sagelib with setup.py without running configure first (as some distros do) since sage-env-config doesn't exist in that case. At least sage-env and sage-env-config should be optional.

[gh-Shlokatadistance]

Can this build also configure a better link or communication between SAGE_LOCAL or SAGE_SCRIPTS_DIR variables?

[mkoeppe]

Replying to gh-Shlokatadistance:

Can this build also configure a better link or communication between SAGE_LOCAL or SAGE_SCRIPTS_DIR variables?

Take a look at #25486