Opened 4 years ago

Last modified 2 months ago

#21558 new defect

IPython 5 / python-prompt-toolkit not usable on dumb terminals (inside Emacs comint)

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-7.4
Component: user interface Keywords:
Cc: darthandrus@…, jsrn, vbraun, dimpase, fbissey, charpent, stakemori, novoselt, jhpalmieri Merged in:
Authors: Reviewers:
Report Upstream: Reported upstream. Developers acknowledge bug. Work issues:
Branch: Commit:
Dependencies: #28197 Stopgaps:

Description

This ticket tracks on our side the following issues:

These issues cause sage-mode to fail (#21227).

Change History (5)

comment:1 Changed 4 years ago by novoselt

  • Cc novoselt added

comment:2 Changed 9 months ago by mkoeppe

  • Report Upstream changed from Reported upstream. No feedback yet. to Reported upstream. Developers acknowledge bug.

comment:3 Changed 9 months ago by mkoeppe

A fix has been merged into prompt-toolkit master.

comment:4 Changed 9 months ago by mkoeppe

  • Dependencies set to #28197

It appears to be in the 3.0.3 release. The 3.x releases are python3 only. Sage currently uses IPython 5, which is using prompt-toolkit 1.x.

comment:5 Changed 2 months ago by mkoeppe

  • Cc jhpalmieri added

After #28197, we have prompt-toolkit 3.0.3. Something has changed, but TERM=dumb ./sage now has strange echo behavior.

This is not very important for us any more after #25363 (--simple-prompt), noting that the shortcomings of simple-prompt pointed out in https://github.com/prompt-toolkit/python-prompt-toolkit/issues/390#issuecomment-246825655 have been fixed.

Note: See TracTickets for help on using tickets.