Opened 5 years ago

Last modified 3 years ago

#21557 needs_work enhancement

Overconvergent Modular Symbols: implement random_element()

Reported by: asteele Owned by:
Priority: minor Milestone: sage-8.0
Component: modular forms Keywords: OMS, p-adic, L-function, sd87
Cc: roed Merged in:
Authors: Ander Steele Reviewers:
Report Upstream: N/A Work issues:
Branch: public/ticket/21557 (Commits, GitHub, GitLab) Commit: 5c1b1d19c87c3e2e2e95d82778b862289bee820e
Dependencies: Stopgaps:

Status badges

Description

The Overconvergent Modular Symbols package contains some (buggy) code for creating random overconvergent modular symbols, but currently raises NotImplementedError?. The existing code needs to be fixed and modified to handle general congruence subgroups.

Change History (11)

comment:1 Changed 5 years ago by asteele

  • Branch set to u/asteele/random_element
  • Commit set to c21647baf5aa3c1f8b584727b94708997169cd89

comment:2 Changed 5 years ago by chapoton

one failing doctest, because you should import DirichletGroup?

comment:3 Changed 5 years ago by git

  • Commit changed from c21647baf5aa3c1f8b584727b94708997169cd89 to 202cc92bea6b14513683ddd2b56b66f61ac764d9

Branch pushed to git repo; I updated commit sha1. New commits:

202cc92add DirichletGroup to imports

comment:4 Changed 5 years ago by chapoton

one failing doctest:

File "src/sage/modular/pollack_stevens/space.py", line 715, in sage.modular.pollack_stevens.space.PollackStevensModularSymbolspace.random_element
Failed example:
    M.random_element(10)
Expected:
    Traceback (most recent call last):
    ...
    NotImplementedError
Got:
    Modular symbol of level 11 with values in Space of 11-adic distributions with k=2 action and precision cap 20

comment:5 Changed 5 years ago by chapoton

  • Milestone changed from sage-7.4 to sage-8.0

Also you need to set the status to "needs_review" if you want this to enter sage.

comment:6 Changed 4 years ago by chapoton

ping ?

comment:7 Changed 4 years ago by git

  • Commit changed from 202cc92bea6b14513683ddd2b56b66f61ac764d9 to 72da74e18b6d35f5b4e8382f045bbe5f751fcc39

Branch pushed to git repo; I updated commit sha1. New commits:

40cd20cMerge master into random_element
72da74eFix obsolete (and wrong) doctest.

comment:8 Changed 4 years ago by asteele

  • Status changed from new to needs_review

comment:9 Changed 4 years ago by roed

  • Keywords sd87 added

comment:10 Changed 4 years ago by davidloeffler

  • Status changed from needs_review to needs_work

The first thing I tried resulted in an error message:

sage: F = PollackStevensModularSymbols(Gamma0(11), 2)
sage: F.random_element()
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
<ipython-input-4-074c74c306de> in <module>()
----> 1 F.random_element()
...
ValueError: You can only compute the valuation with respect to a integer larger than 1.

So did the second:

sage: D = OverconvergentDistributions(4, 7, prec_cap=10)
sage: F = PollackStevensModularSymbols(Gamma0(21), coefficients=D)
sage: F.random_element()
---------------------------------------------------------------------------
NameError                                 Traceback (most recent call last)
<ipython-input-19-074c74c306de> in <module>()
----> 1 F.random_element()

/storage/masiao/sage/local/lib/python2.7/site-packages/sage/modular/pollack_stevens/space.pyc in random_element(self, M)
    758                 t += D[g] * manin.gammas[g] - D[g]
    759             else:
--> 760                 if g in MR.reps_with_two_torsion():  # What is MR ??
    761                     t -= D[g]
    762                 else:

NameError: global name 'MR' is not defined

comment:11 Changed 3 years ago by chapoton

  • Branch changed from u/asteele/random_element to public/ticket/21557
  • Commit changed from 72da74e18b6d35f5b4e8382f045bbe5f751fcc39 to 5c1b1d19c87c3e2e2e95d82778b862289bee820e

New commits:

75b2119Merge branch 'u/asteele/random_element' in 8.4.b1
5c1b1d1some details in #21557
Note: See TracTickets for help on using tickets.