Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#21554 closed task (fixed)

Document noninteger assumption in Maxima

Reported by: kcrisman Owned by: aashu12
Priority: trivial Milestone: sage-7.4
Component: documentation Keywords: beginner
Cc: Merged in:
Authors: Ashutosh Ahelleya Reviewers: Ralf Stephan
Report Upstream: N/A Work issues:
Branch: u/aashu12/c7acfd690f5283e956bcce87f6a98668da21c798 (Commits, GitHub, GitLab) Commit: 75602b22adb0f7ef8f01f4a9f64007cecdedcc8c
Dependencies: Stopgaps:

Status badges

Description

It turns out that not only can one declare integer, one can declare noninteger. See ​here. Let's add an example pointing this out, perhaps with the example from ​this question.

Change History (22)

comment:1 Changed 4 years ago by souravsingh

I am interested in working on this. How do I start?

comment:2 follow-up: Changed 4 years ago by rws

First, ​http://doc.sagemath.org/html/en/developer/index.html

and please use the Google group sage-devel for questions unrelated to this specific ticket.

comment:3 Changed 4 years ago by aashu12

I am interested in adding an example to fix this. How do I know in which part of the sage directory is this located? I guess it is in src/doc/

Last edited 4 years ago by aashu12 (previous) (diff)

comment:4 Changed 4 years ago by kcrisman

Nope, you would have to find an appropriate place. The src/doc is mostly auto-generated. Instead, try to add to the documentation for the command mentioned in the ​question mentioned in the ticket description. The solve command is in src/sage/symbolic/relation.py or at least that is one place.

comment:5 Changed 4 years ago by aashu12

Thanks :)

comment:6 Changed 4 years ago by kcrisman

No problem!

comment:7 in reply to: ↑ 2 Changed 4 years ago by aashu12

  • Owner changed from (none) to aashu12

comment:8 Changed 4 years ago by aashu12

  • Branch set to u/aashu12/documentation

comment:9 Changed 4 years ago by aashu12

  • Commit set to c7acfd690f5283e956bcce87f6a98668da21c798
  • Status changed from new to needs_review

New commits:

​c7acfd6Fixes #21554

comment:10 follow-up: Changed 4 years ago by rws

  • Reviewers set to Ralf Stephan
  • Status changed from needs_review to positive_review

Looks good. Please insert your real name in the Author field.

comment:11 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

Author name missing

comment:12 Changed 4 years ago by aashu12

  • Authors set to Ashutosh Ahelleya

comment:13 Changed 4 years ago by aashu12

  • Status changed from needs_work to needs_review

comment:14 Changed 4 years ago by rws

  • Status changed from needs_review to positive_review

In such cases you can set positive again yourself.

comment:15 Changed 4 years ago by vbraun

  • Branch changed from u/aashu12/documentation to c7acfd690f5283e956bcce87f6a98668da21c798
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:16 in reply to: ↑ 10 ; follow-up: Changed 4 years ago by dimpase

  • Commit c7acfd690f5283e956bcce87f6a98668da21c798 deleted

Replying to rws:

Looks good. Please insert your real name in the Author field.

With all respect, 

In case one of the solutions while solving an equation is a real number::

makes little sense, in particular in the context of this ticket. I'm requesting a clarification on #21946

comment:17 in reply to: ↑ 16 Changed 4 years ago by aashu12

Replying to dimpase:

With all respect, 

In case one of the solutions while solving an equation is a real number::

makes little sense, in particular in the context of this ticket. I'm requesting a clarification on #21946

Yea, I can change that statement to a more clear one. Also, #21946 and this ticket are not dependent.

comment:18 Changed 4 years ago by aashu12

  • Branch changed from c7acfd690f5283e956bcce87f6a98668da21c798 to u/aashu12/c7acfd690f5283e956bcce87f6a98668da21c798

comment:19 Changed 4 years ago by dimpase

  • Commit set to 75602b22adb0f7ef8f01f4a9f64007cecdedcc8c

this ticket is closed. Any changes to the branches here will be ignored. (So it should go to another ticket, say #21946) But still, your branch did not and does not make sense. The purpose of this ticket is to document and provide a test for noninteger assumption. E.g. 

sage: var('K')
K
sage: assume(K, 'noninteger')
sage: solve([K^2==1],K)
[]

The doctring should say what this test doing: it is showing how to use this type of assumption, and not something about reals. (Yes, I agree that the link for an example in the ticket description is somewhat misleading, but, well...)

New commits:

​c7acfd6Fixes #21554
​75602b2Fixed Documentation

comment:20 follow-up: Changed 4 years ago by dimpase

even better example: 

sage: solve([K^3==1],K)
[K == 1/2*I*sqrt(3) - 1/2, K == -1/2*I*sqrt(3) - 1/2]

comment:21 in reply to: ↑ 20 Changed 4 years ago by aashu12

Replying to dimpase:

even better example: 

sage: solve([K^3==1],K)
[K == 1/2*I*sqrt(3) - 1/2, K == -1/2*I*sqrt(3) - 1/2]

Yea, I will replace the existing example with the example given above in #21946

Note: See TracTickets for help on using tickets.