Opened 5 years ago

Closed 5 years ago

#21552 closed defect (fixed)

Add a fix for Python bug #20108

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.4
Component: packages: standard Keywords:
Cc: charpent Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: cf0621d (Commits, GitHub, GitLab) Commit: cf0621dbfac2012f92ed4840b0e8f7c0c1681ee5
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

ipywidgets uses inspect.getcallargs which has a subtle bug in case the inspected function has a func keyword argument: http://bugs.python.org/issue20108

This is fixed in Python 3.3 and later. We can easily backport the fix to Python 2.7.

While I'm at it, I also removed sdist.patch (which was about .hg directories and is clearly no longer relevant) and renamed some patches with the Python issue number.

Note to the release manager: ideally, this would be merged together with #21441 since both tickets trigger recompilation of all Python packages.

Change History (6)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/add_a_fix_for_python_bug__20108

comment:2 Changed 5 years ago by jdemeyer

  • Commit set to cf0621dbfac2012f92ed4840b0e8f7c0c1681ee5
  • Description modified (diff)
  • Status changed from new to needs_review

New commits:

cf0621dFix Python bug #20108: getcallargs() with func keyword

comment:3 Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:4 Changed 5 years ago by jdemeyer

  • Cc charpent added

comment:5 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Good for upstream, so good for Sage.

comment:6 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/add_a_fix_for_python_bug__20108 to cf0621dbfac2012f92ed4840b0e8f7c0c1681ee5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.