Opened 6 years ago

Closed 6 years ago

#21552 closed defect (fixed)

Add a fix for Python bug #20108

Reported by: Jeroen Demeyer Owned by:
Priority: major Milestone: sage-7.4
Component: packages: standard Keywords:
Cc: Emmanuel Charpentier Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: cf0621d (Commits, GitHub, GitLab) Commit: cf0621dbfac2012f92ed4840b0e8f7c0c1681ee5
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

ipywidgets uses inspect.getcallargs which has a subtle bug in case the inspected function has a func keyword argument:

This is fixed in Python 3.3 and later. We can easily backport the fix to Python 2.7.

While I'm at it, I also removed sdist.patch (which was about .hg directories and is clearly no longer relevant) and renamed some patches with the Python issue number.

Note to the release manager: ideally, this would be merged together with #21441 since both tickets trigger recompilation of all Python packages.

Change History (6)

comment:1 Changed 6 years ago by Jeroen Demeyer

Branch: u/jdemeyer/add_a_fix_for_python_bug__20108

comment:2 Changed 6 years ago by Jeroen Demeyer

Commit: cf0621dbfac2012f92ed4840b0e8f7c0c1681ee5
Description: modified (diff)
Status: newneeds_review

New commits:

cf0621dFix Python bug #20108: getcallargs() with func keyword

comment:3 Changed 6 years ago by Jeroen Demeyer

Description: modified (diff)

comment:4 Changed 6 years ago by Jeroen Demeyer

Cc: Emmanuel Charpentier added

comment:5 Changed 6 years ago by Travis Scrimshaw

Reviewers: Travis Scrimshaw
Status: needs_reviewpositive_review

Good for upstream, so good for Sage.

comment:6 Changed 6 years ago by Volker Braun

Branch: u/jdemeyer/add_a_fix_for_python_bug__20108cf0621dbfac2012f92ed4840b0e8f7c0c1681ee5
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.