Opened 6 years ago
Closed 6 years ago
#21549 closed task (fixed)
Remove `sage-mode` as an optional package
Reported by: | jsrn | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.4 |
Component: | packages: optional | Keywords: | emacs, sage_mode |
Cc: | iandrus, vbraun, dimpase, fbissey, charpent, stakemori | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | d15650f (Commits, GitHub, GitLab) | Commit: | d15650f1229fb9cb35ce96d94e871c13b660d666 |
Dependencies: | Stopgaps: |
Description (last modified by )
The Sage-in-Emacs interface sage-mode
is broken since IPython 5.0, see #21227. sage-shell-mode
by stakemori is a very good alternative. This is distributed using the Emacs package manager MELPA, which should be familiar to any Emacs user (in both senses of the word "should"), so there is no real reason to distribute that with Sage or even have an spkg for it.
The suggestion is therefore simply to remove sage-mode
as an optional package from Sage.
Change History (12)
comment:1 Changed 6 years ago by
comment:2 Changed 6 years ago by
+1.
comment:3 Changed 6 years ago by
Sage-mode is an optional package for the record
comment:4 Changed 6 years ago by
- Component changed from packages: standard to packages: optional
- Description modified (diff)
- Summary changed from Remove `sage-mode` as a standard package to Remove `sage-mode` as an optional package
ah, indeed, but still, it is broken beyond repair.
comment:5 Changed 6 years ago by
- Branch set to u/mkoeppe/remove__sage_mode__as_an_optional_package
comment:6 Changed 6 years ago by
- Commit set to d15650f1229fb9cb35ce96d94e871c13b660d666
- Priority changed from major to blocker
- Status changed from new to needs_review
New commits:
d15650f | Delete sage_mode package
|
comment:7 Changed 6 years ago by
comment:8 Changed 6 years ago by
- Status changed from needs_review to positive_review
LVGTM (disclaimer - I am a vim user :-))
comment:9 Changed 6 years ago by
- Priority changed from blocker to major
comment:10 Changed 6 years ago by
Blocker or not, I think this package should be removed in the 7.4 release.
comment:11 Changed 6 years ago by
- Reviewers set to Dima Pasechnik
comment:12 Changed 6 years ago by
- Branch changed from u/mkoeppe/remove__sage_mode__as_an_optional_package to d15650f1229fb9cb35ce96d94e871c13b660d666
- Resolution set to fixed
- Status changed from positive_review to closed
+1. I suppose this should be announced on sage-develop.