Opened 4 years ago
Closed 4 months ago
#21525 closed enhancement (invalid)
package autotools: Don't depend on $SAGE_LOCAL
Reported by:  mkoeppe  Owned by:  

Priority:  major  Milestone:  sageduplicate/invalid/wontfix 
Component:  packages: experimental  Keywords:  
Cc:  jdemeyer, embray, fbissey, vbraun, dimpase, vdelecroix, tscrim, leif, novoselt  Merged in:  
Authors:  Matthias Koeppe  Reviewers:  François Bissey, Dima Pasechnik 
Report Upstream:  N/A  Work issues:  
Branch:  u/mkoeppe/package_autotools__don_t_depend_on__sage_local (Commits)  Commit:  572e940d2f6d8c3b74a14912839c544a1e02472b 
Dependencies:  Stopgaps: 
Description (last modified by )
The wrapper script installed by our autotools package (from build/pkgs/autotools/autofoo
)
depends on the SAGE_LOCAL variable. Not a good idea; we can do better.
(This is a step towards this goal of #21566: "By allowing the user to choose the installation hierarchy, there are new requirements. What is installed there should run without requiring environment variables to be set.")
Change History (16)
comment:1 Changed 4 years ago by
 Branch set to u/mkoeppe/package_autotools__don_t_depend_on__sage_local
comment:2 Changed 4 years ago by
 Cc embray fbissey vbraun dimpase added
 Commit set to 557d4d939df4c2a852bf41fdd015c3ff3f98ff0f
 Status changed from new to needs_review
comment:3 Changed 4 years ago by
 Commit changed from 557d4d939df4c2a852bf41fdd015c3ff3f98ff0f to 572e940d2f6d8c3b74a14912839c544a1e02472b
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
572e940  Substitute full @SAGE_LOCAL@ in autofoo scripts instead of referring to $SAGE_LOCAL

comment:4 Changed 4 years ago by
 Description modified (diff)
comment:5 followup: ↓ 6 Changed 4 years ago by
What is autofoo?
comment:6 in reply to: ↑ 5 Changed 4 years ago by
Replying to embray:
What is autofoo?
It's a script which gets installed as autoconf
, automake
, ... to automatically run the "correct" version of autoconf
, automake
, ...
comment:7 Changed 4 years ago by
Needs review  which is easy and independent of other build tickets. Can test by using
./sage f autotools export PATH=`pwd`/local/bin:$PATH autoreconf
(outside of a sagesh
).
comment:8 Changed 4 years ago by
 Cc vdelecroix added
comment:9 Changed 4 years ago by
 Cc tscrim added
comment:10 Changed 4 years ago by
 Cc leif added
comment:11 Changed 4 years ago by
 Cc novoselt added
comment:12 Changed 4 years ago by
This tiny patch still needs review...
comment:13 Changed 4 years ago by
 Reviewers set to François Bissey
 Status changed from needs_review to needs_work
Please bump the package version. We need a way to tell people they have to update their package, adding a .p0
should do just that.
comment:14 Changed 5 months ago by
 Milestone changed from sage7.4 to sageduplicate/invalid/wontfix
 Status changed from needs_work to needs_review
Let's close this ticket in favor of the removal of the autotools package (#29174).
comment:15 Changed 5 months ago by
 Reviewers changed from François Bissey to François Bissey, Dima Pasechnik
 Status changed from needs_review to positive_review
ok
comment:16 Changed 4 months ago by
 Resolution set to invalid
 Status changed from positive_review to closed
New commits:
Substitute full @SAGE_LOCAL@ in autofoo scripts instead of referring to /Users/mkoeppe/s/sage/sagerebasing/very/far/away/but/still/local