Opened 3 years ago

Last modified 3 years ago

#21525 needs_work enhancement

package autotools: Don't depend on $SAGE_LOCAL

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-7.4
Component: packages: experimental Keywords:
Cc: jdemeyer, embray, fbissey, vbraun, dimpase, vdelecroix, tscrim, leif, novoselt Merged in:
Authors: Matthias Koeppe Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: u/mkoeppe/package_autotools__don_t_depend_on__sage_local (Commits) Commit: 572e940d2f6d8c3b74a14912839c544a1e02472b
Dependencies: Stopgaps:

Description (last modified by mkoeppe)

The wrapper script installed by our autotools package (from build/pkgs/autotools/autofoo) depends on the SAGE_LOCAL variable. Not a good idea; we can do better.

(This is a step towards this goal of #21566: "By allowing the user to choose the installation hierarchy, there are new requirements. What is installed there should run without requiring environment variables to be set.")

Change History (13)

comment:1 Changed 3 years ago by mkoeppe

  • Branch set to u/mkoeppe/package_autotools__don_t_depend_on__sage_local

comment:2 Changed 3 years ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Cc embray fbissey vbraun dimpase added
  • Commit set to 557d4d939df4c2a852bf41fdd015c3ff3f98ff0f
  • Status changed from new to needs_review

New commits:

557d4d9Substitute full @SAGE_LOCAL@ in autofoo scripts instead of referring to /Users/mkoeppe/s/sage/sage-rebasing/very/far/away/but/still/local

comment:3 Changed 3 years ago by git

  • Commit changed from 557d4d939df4c2a852bf41fdd015c3ff3f98ff0f to 572e940d2f6d8c3b74a14912839c544a1e02472b

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

572e940Substitute full @SAGE_LOCAL@ in autofoo scripts instead of referring to $SAGE_LOCAL

comment:4 Changed 3 years ago by mkoeppe

  • Description modified (diff)

comment:5 follow-up: Changed 3 years ago by embray

What is autofoo?

comment:6 in reply to: ↑ 5 Changed 3 years ago by jdemeyer

Replying to embray:

What is autofoo?

It's a script which gets installed as autoconf, automake, ... to automatically run the "correct" version of autoconf, automake, ...

comment:7 Changed 3 years ago by mkoeppe

Needs review - which is easy and independent of other build tickets. Can test by using

  ./sage -f autotools
  export PATH=`pwd`/local/bin:$PATH
  autoreconf

(outside of a sage-sh).

comment:8 Changed 3 years ago by mkoeppe

  • Cc vdelecroix added

comment:9 Changed 3 years ago by mkoeppe

  • Cc tscrim added

comment:10 Changed 3 years ago by mkoeppe

  • Cc leif added

comment:11 Changed 3 years ago by mkoeppe

  • Cc novoselt added

comment:12 Changed 3 years ago by mkoeppe

This tiny patch still needs review...

comment:13 Changed 3 years ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to needs_work

Please bump the package version. We need a way to tell people they have to update their package, adding a .p0 should do just that.

Note: See TracTickets for help on using tickets.