Opened 4 years ago

Closed 4 years ago

#21523 closed enhancement (fixed)

py3 range: using new syntax in combinat folder

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.4
Component: python3 Keywords:
Cc: tscrim, jmantysalo, jdemeyer Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c76bdfa (Commits) Commit: c76bdfa082cea47e075996560954e6b3af4e0d22
Dependencies: Stopgaps:

Description

in this ticket, most of the usage of range inside the combinat folder (both code and doc) has been converted to use the python3 syntax, where range is an iterator.

Change History (8)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/21523
  • Commit set to 16e00512cdd981c66ce1e9afc5ab0e20acf3e12e
  • Status changed from new to needs_review

New commits:

16e0051converting range to py3 syntax in combinat folder

comment:2 Changed 4 years ago by git

  • Commit changed from 16e00512cdd981c66ce1e9afc5ab0e20acf3e12e to eda94128e5911fa57e372f0e4152c9297b6285ba

Branch pushed to git repo; I updated commit sha1. New commits:

eda9412fixing sageinspect (sourceline)

comment:3 Changed 4 years ago by chapoton

  • Cc tscrim jmantysalo jdemeyer added

green bot

comment:4 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 4 years ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict

comment:6 Changed 4 years ago by git

  • Commit changed from eda94128e5911fa57e372f0e4152c9297b6285ba to c76bdfa082cea47e075996560954e6b3af4e0d22

Branch pushed to git repo; I updated commit sha1. New commits:

c76bdfaMerge branch 'u/chapoton/21523' in 7.4.b6

comment:7 Changed 4 years ago by chapoton

  • Status changed from needs_work to positive_review

after a trivial rebase, setting back to positive review

comment:8 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/21523 to c76bdfa082cea47e075996560954e6b3af4e0d22
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.