Opened 6 years ago
Last modified 19 months ago
#21516 closed defect
Fix sagelib sdist (src/setup.py sdist) — at Version 2
Reported by: | mkoeppe | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | build | Keywords: | |
Cc: | jdemeyer, vbraun, embray, leif, fbissey, dimpase, mjo, chapoton | Merged in: | |
Authors: | Matthias Koeppe | Reviewers: | |
Report Upstream: | N/A | Work issues: | |
Branch: | u/mkoeppe/sagelib_sdist (Commits, GitHub, GitLab) | Commit: | c7964a0047837b76fa265d96780e5b3e07c5284a |
Dependencies: | #21480 | Stopgaps: |
Description (last modified by )
This ticket adds some targets to src/Makefile.in
: sdist
and sdistcheck
.
The latter, after building an sdist
(using distutils
), unpacks it into a subdirectory, and builds and installs (into SAGE_LOCAL) from there.
(cd src && make sdist)
gives the following warnings. They need fixing.
warning: sdist: standard file not found: should have one of README, README.txt reading manifest template 'MANIFEST.in' warning: sdist: MANIFEST.in, line 6: 'recursive-include' expects <dir> <pattern1> <pattern2> ... warning: no previously-included files matching '*.h' found under directory 'sage/ext/interpreters' warning: no previously-included files found matching 'sage/libs/pari/gen.h' warning: no previously-included files found matching 'sage/modular/arithgroup/farey_symbol.h' warning: no previously-included files found matching 'sage/rings/real_mpfi.h' warning: no previously-included files found matching 'sage/symbolic/pynac.h' warning: no directories found matching 'doc/common/static' warning: no files found matching 'doc/en/bordeaux_2008/birch.png' warning: no files found matching 'doc/en/bordeaux_2008/modpcurve.png' no previously-included directories found matching 'doc/output'
There is something more seriously wrong with the sdist. The sage that is built from there (using (cd src && make sdistcheck)
) crashes as follows.
/Users/mkoeppe/s/sage/sage-rebasing/src/sage/ext/interpreters/wrapper_rdf.pxd in init sage.plot.plot3d.parametric_surface (build/cythonized/sage/plot/plot3d/parametric_surface.c:11409)() 1 # Automatically generated by sage_setup/autogen/interpreters.pyc. Do not edit! 2 3 from cpython cimport PyObject 4 5 from sage.ext.fast_callable cimport Wrapper 6 ----> 7 cdef class Wrapper_rdf(Wrapper): global cdef = undefined global Wrapper_rdf = undefined global Wrapper = undefined 8 cdef int _n_args 9 cdef double* _args 10 cdef int _n_constants 11 cdef double* _constants 12 cdef object _list_py_constants 13 cdef int _n_py_constants 14 cdef PyObject** _py_constants 15 cdef int _n_stack 16 cdef double* _stack 17 cdef int _n_code 18 cdef int* _code 19 cdef object _domain 20 cdef bint call_c(self, 21 double* args, 22 double* result) except 0 ImportError: No module named wrapper_rdf
This needs fixing.
The branch is on top of #21480.
Change History (2)
comment:1 Changed 6 years ago by
- Branch set to u/mkoeppe/sagelib_sdist
comment:2 Changed 6 years ago by
- Cc jdemeyer vbraun embray leif fbissey added
- Commit set to c7964a0047837b76fa265d96780e5b3e07c5284a
- Dependencies set to #21480
- Description modified (diff)
Note: See
TracTickets for help on using
tickets.
Last 10 new commits:
Ignore generated files
Reword TODO item
Fix typo in comment
Respect environment variable MAKE
beautification
More comments
Remove --buildbase code
Pass SAGE_SRC to generate_py_source.mk
Add new file to MANIFEST.in
sdist* Makefile targets