Opened 5 years ago

Last modified 5 weeks ago

#21508 new task

Clean up src/setup.py to bring it to standard distutils behavior — at Version 9

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.6
Component: build Keywords:
Cc: jdemeyer, vbraun, embray, leif, fbissey, was, mmezzarobba, dimpase, jhpalmieri Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #20596 Stopgaps:

Status badges

Description (last modified by mkoeppe)

All building (including cythonizing) should done within the call to setup, not before it.

In particular,

  • src/setup.py --help should return immediately.
  • src/setup.py clean should not build anything but just clean (and everything that is now done by make clean in the src directory should be done by it)

Also see: #21516 - Fix sagelib sdist (src/setup.py sdist)

Change History (9)

comment:1 Changed 5 years ago by jdemeyer

  • Dependencies set to #20596

comment:2 Changed 5 years ago by jdemeyer

  • Type changed from defect to task

comment:3 Changed 5 years ago by mkoeppe

  • Description modified (diff)

comment:4 Changed 5 years ago by mkoeppe

  • Summary changed from Clean up src/setup.py to Clean up src/setup.py, fix 'setup.py sdist'

comment:5 Changed 5 years ago by mkoeppe

  • Cc leif fbissey added
  • Description modified (diff)

comment:6 Changed 5 years ago by mkoeppe

  • Description modified (diff)
  • Summary changed from Clean up src/setup.py, fix 'setup.py sdist' to Clean up src/setup.py to bring it to standard distutils behavior

comment:7 Changed 5 years ago by mkoeppe

  • Cc was mmezzarobba added
  • Description modified (diff)

comment:8 Changed 5 years ago by embray

and everything that is now done by make clean should be done by it

By which you mean the makefile in src/ right?

comment:9 Changed 5 years ago by mkoeppe

  • Description modified (diff)

Yes -- I've clarified it in the description.

Note: See TracTickets for help on using tickets.