Opened 6 years ago

Last modified 3 months ago

#21508 new task

Clean up src/setup.py to bring it to standard distutils behavior — at Version 12

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-9.8
Component: build Keywords:
Cc: Jeroen Demeyer, Volker Braun, Erik Bray, Leif Leonhardy, François Bissey, William Stein, Marc Mezzarobba, Dima Pasechnik, John Palmieri Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #21480, #21604, #21600 Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

All building (including cythonizing) should done within the call to setup, not before it.

Sub-tasks:

  • #21480: Make sagelib setup.py self-contained and independent of SAGE_ROOT
  • #21604: Cleaning up stale installed files in setup()
  • #21600: Use custom build_ext to compile Cython code

In particular,

  • src/setup.py --help should return immediately.
  • src/setup.py clean should not build anything but just clean (and everything that is now done by make clean in the src directory should be done by it)

Also see: #21516 - Fix sagelib sdist (src/setup.py sdist)

Change History (12)

comment:1 Changed 6 years ago by Jeroen Demeyer

Dependencies: #20596

comment:2 Changed 6 years ago by Jeroen Demeyer

Type: defecttask

comment:3 Changed 6 years ago by Matthias Köppe

Description: modified (diff)

comment:4 Changed 6 years ago by Matthias Köppe

Summary: Clean up src/setup.pyClean up src/setup.py, fix 'setup.py sdist'

comment:5 Changed 6 years ago by Matthias Köppe

Cc: Leif Leonhardy François Bissey added
Description: modified (diff)

comment:6 Changed 6 years ago by Matthias Köppe

Description: modified (diff)
Summary: Clean up src/setup.py, fix 'setup.py sdist'Clean up src/setup.py to bring it to standard distutils behavior

comment:7 Changed 6 years ago by Matthias Köppe

Cc: William Stein Marc Mezzarobba added
Description: modified (diff)

comment:8 Changed 6 years ago by Erik Bray

and everything that is now done by make clean should be done by it

By which you mean the makefile in src/ right?

comment:9 Changed 6 years ago by Matthias Köppe

Description: modified (diff)

Yes -- I've clarified it in the description.

comment:10 Changed 6 years ago by Jeroen Demeyer

Dependencies: #20596#21600
Description: modified (diff)

comment:11 Changed 6 years ago by Jeroen Demeyer

Dependencies: #21600#21604, #21600

comment:12 Changed 6 years ago by Jeroen Demeyer

Dependencies: #21604, #21600#21480, #21604, #21600
Description: modified (diff)
Note: See TracTickets for help on using tickets.