Opened 6 years ago

Closed 6 years ago

#21492 closed defect (fixed)

autotools spkg-install should not use "which"

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-7.4
Component: packages: experimental Keywords:
Cc: Erik Bray, Jeroen Demeyer, Jean-Pierre Flori, François Bissey, Volker Braun Merged in:
Authors: Matthias Koeppe Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: 7eeb66f (Commits, GitHub, GitLab) Commit: 7eeb66f23688507a03baac4c37835471ec31bda9
Dependencies: Stopgaps:

Status badges

Description

[autotools-20141105] ./spkg-install: line 110: which: command not found
[autotools-20141105] make[2]: Entering directory `/home/sage/CLONED/sage/local/var/tmp/sage/build/autotools-20141105/build'
[autotools-20141105] ( cd /home/sage/CLONED/sage/local/var/tmp/sage/build/autotools-20141105/src/autoconf && git archive --format=tar --prefix=autoconf-2.13.rc1/ autoconf-2-13-rc1 ) | tar xf -
[autotools-20141105] make[2]: -c: Command not found

Change History (7)

comment:1 Changed 6 years ago by Matthias Köppe

Branch: u/mkoeppe/autotools_spkg_install_should_not_use__which_

comment:2 Changed 6 years ago by Matthias Köppe

Authors: Matthias Koeppe
Commit: 7eeb66f23688507a03baac4c37835471ec31bda9
Status: newneeds_review

1-line patch, needs review


New commits:

7eeb66fRemove useless use of 'which'

comment:3 Changed 6 years ago by Matthias Köppe

Cc: François Bissey added

comment:4 Changed 6 years ago by Matthias Köppe

Cc: Volker Braun added

comment:5 Changed 6 years ago by Erik Bray

Reviewers: Erik Bray
Status: needs_reviewpositive_review

See also #21486

comment:6 Changed 6 years ago by Matthias Köppe

Thanks!

comment:7 Changed 6 years ago by Volker Braun

Branch: u/mkoeppe/autotools_spkg_install_should_not_use__which_7eeb66f23688507a03baac4c37835471ec31bda9
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.