Changes between Version 114 and Version 126 of Ticket #21480


Ignore:
Timestamp:
09/29/16 15:30:40 (3 years ago)
Author:
embray
Comment:

For generate_py_source.mk, we could even get rid of that and not invoke make at all. For simplicity's sake I could do that as a separate ticket with this one as a dependency.

To add, I especially don't like what this branch currently does as far as unconditionally invoking make every time setup.py is run. But I'm happy to ignore it for now as long as we follow up with further work--I'm opening a new ticket now.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21480

    • Property Status changed from needs_review to positive_review
  • Ticket #21480 – Description

    v114 v126  
    1616 - `pip install` keeps the source directory clean, building instead in a temporary directory, by copying the sources.
    1717 `pip install` also offers options `--build` to select a build directory, but there are some pip issues: [https://github.com/pypa/pip/issues/2060 2060], [https://github.com/pypa/pip/issues/2053 2053], [https://github.com/pypa/pip/issues/804 804] that affect this
    18  - #14807 has some tricks to making VPATH builds work without copying all python source files. But it uses automake instead of setup.py; we will not do this in our ticket.
     18 - #14807 has some tricks to making VPATH builds work without copying all python source files. But it uses automake instead of setup.sh; we will not do this in our ticket.