Opened 6 years ago

Closed 6 years ago

#21476 closed enhancement (fixed)

Get rid of six.moves.range in Cython files

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.4
Component: cython Keywords:
Cc: tscrim, chapoton Merged in:
Authors: Jeroen Demeyer Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 5462926 (Commits, GitHub, GitLab) Commit: 54629269f8d01d311489388bd6ccecb52a19a7d6
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

As explained in #21470, in Cython code, it is better to use xrange() than six.moves.range().

Change History (5)

comment:1 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 6 years ago by jdemeyer

  • Branch set to u/jdemeyer/get_rid_of_six_moves_range_in_cython_files

comment:3 Changed 6 years ago by jdemeyer

  • Commit set to 54629269f8d01d311489388bd6ccecb52a19a7d6
  • Status changed from new to needs_review

New commits:

5462926In Cython code, use xrange instead of six.moves.range

comment:4 Changed 6 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, thanks. Sadly, there will be 3 more that will come from #21375 (closed but not yet in beta)

Last edited 6 years ago by chapoton (previous) (diff)

comment:5 Changed 6 years ago by vbraun

  • Branch changed from u/jdemeyer/get_rid_of_six_moves_range_in_cython_files to 54629269f8d01d311489388bd6ccecb52a19a7d6
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.