Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#21435 closed enhancement (fixed)

get rid of cmp comparison for words

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.4
Component: combinatorics Keywords:
Cc: slabbe, tscrim, darij, vdelecroix Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 8caaee7 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description

Because this is necessary to move towards python3

Change History (7)

comment:1 Changed 5 years ago by chapoton

  • Branch set to u/chapoton/21435
  • Cc slabbe tscrim darij vdelecroix added
  • Commit set to 6082e932df4e87ce592d6c32c16bdac0f2e55d19
  • Status changed from new to needs_review

New commits:

6082e93trac 21435 get rid of cmp for sorting words

comment:2 Changed 5 years ago by chapoton

important ticket, changing letter ordering in words for py3 compatibility, please review

comment:3 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Minor doc formatting:

- ``letter1`` - a letter in the alphabet
- ``letter1`` -- a letter in the alphabet

Once that is changed, you can set a positive review on my behalf.

Version 1, edited 5 years ago by tscrim (previous) (next) (diff)

comment:4 Changed 5 years ago by git

  • Commit changed from 6082e932df4e87ce592d6c32c16bdac0f2e55d19 to 8caaee70e87aa99df6ee3a81736d5ed3d2cff492

Branch pushed to git repo; I updated commit sha1. New commits:

8caaee7trac 21435 detail

comment:5 follow-up: Changed 5 years ago by chapoton

  • Status changed from needs_review to positive_review

ok, done. Thanks a lot Travis.

I am just slightly worried by the fact that I did not do a proper deprecation, and may have broken things for intensive users of words. Of course, this is rather harmless, as most users will just use the standard default increasing alphabetical order, for which nothing has changed.

Let me set this to positive review. If somebody object, please react now.

comment:6 Changed 5 years ago by vbraun

  • Branch changed from u/chapoton/21435 to 8caaee70e87aa99df6ee3a81736d5ed3d2cff492
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:7 in reply to: ↑ 5 Changed 5 years ago by slabbe

  • Commit 8caaee70e87aa99df6ee3a81736d5ed3d2cff492 deleted

If somebody object, please react now.

The ticket got positive review before I have time to look at it. Thank you Travis. Thank you Frédéric for your work towards py3.

Sébastien

Note: See TracTickets for help on using tickets.