Opened 5 years ago

Closed 5 years ago

#21434 closed enhancement (fixed)

Implement conversion MPC -> PARI

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.4
Component: interfaces Keywords:
Cc: defeo Merged in:
Authors: Jeroen Demeyer Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 0be2020 (Commits, GitHub, GitLab) Commit: 0be20205ed5cd8d7c129f4acb98c54d52610ca86
Dependencies: Stopgaps:

Status badges

Description


Change History (9)

comment:1 Changed 5 years ago by jdemeyer

  • Branch set to u/jdemeyer/implement_conversion_mpc____pari

comment:2 Changed 5 years ago by jdemeyer

  • Commit set to 9c82df5843194e158679653aa8d78c34be361c08
  • Status changed from new to needs_review

New commits:

9c82df5Implement conversion MPC -> PARI

comment:3 Changed 5 years ago by git

  • Commit changed from 9c82df5843194e158679653aa8d78c34be361c08 to 40aaa807a2c71b5f733d8fee9de950b99116dda0

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

40aaa80Implement conversion MPC -> PARI

comment:4 Changed 5 years ago by tscrim

Instead of pari(0), wouldn't it be better to use pari.PARI_ZERO? Otherwise LGTM.

comment:5 Changed 5 years ago by jdemeyer

Obviously...

sage: timeit('pari(0r)', number=10^5, repeat=20)
100000 loops, best of 20: 510 ns per loop
sage: timeit('pari.PARI_ZERO', number=10^5, repeat=20)
100000 loops, best of 20: 49.6 ns per loop

comment:6 Changed 5 years ago by git

  • Commit changed from 40aaa807a2c71b5f733d8fee9de950b99116dda0 to 0be20205ed5cd8d7c129f4acb98c54d52610ca86

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0be2020Implement conversion MPC -> PARI

comment:7 Changed 5 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Thanks.

comment:8 Changed 5 years ago by tscrim

  • Status changed from needs_review to positive_review

comment:9 Changed 5 years ago by vbraun

  • Branch changed from u/jdemeyer/implement_conversion_mpc____pari to 0be20205ed5cd8d7c129f4acb98c54d52610ca86
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.