Opened 4 years ago

Closed 4 years ago

#21431 closed enhancement (fixed)

some cleanup in sandpile

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.4
Component: combinatorics Keywords:
Cc: tscrim, jmantysalo, darij, dperkinson Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: c017c7c (Commits) Commit: c017c7c54a29f11d3d788549fadb46ae05802e53
Dependencies: Stopgaps:

Description

  • do not use cmp but key to sort (python3)
  • remove some of the deprecated functions

Change History (6)

comment:1 Changed 4 years ago by chapoton

  • Branch set to u/chapoton/21431
  • Commit set to c017c7c54a29f11d3d788549fadb46ae05802e53
  • Status changed from new to needs_review

New commits:

c017c7csome cleanup in sandpile (cmp and removal of some deprecated functions)

comment:2 Changed 4 years ago by chapoton

  • Cc dperkinson added

comment:3 Changed 4 years ago by tscrim

  • Reviewers set to Travis Scrimshaw

Instead of reversing verts, wouldn't it be easier to use the negative distance? Granted, this adds some complexity to the code, but it would be faster. I don't really hold a strong opinion either way, and whatever you decide, you can set a positive review on my behalf.

comment:4 Changed 4 years ago by chapoton

  • Status changed from needs_review to positive_review

I tried everything, and this was the only way to have no failing doctest.

I am setting to positive review, thanks Travis.

comment:5 Changed 4 years ago by tscrim

Hmm. *shrugs* Thanks.

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/chapoton/21431 to c017c7c54a29f11d3d788549fadb46ae05802e53
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.