Opened 5 years ago

Closed 5 years ago

#21414 closed enhancement (fixed)

py3: remove one cmp in matrix2

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.4
Component: python3 Keywords:
Cc: tscrim, jdemeyer, aapitzsch Merged in:
Authors: Frédéric Chapoton Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: 700320e (Commits, GitHub, GitLab) Commit: 700320e17544b36ef34f0212fad9b825450fa646
Dependencies: Stopgaps:

Status badges

Description

as a step to py3, let us use a key to sort, not cmp

Change History (3)

comment:1 Changed 5 years ago by chapoton

  • Branch set to public/21414
  • Cc tscrim jdemeyer aapitzsch added
  • Commit set to 700320e17544b36ef34f0212fad9b825450fa646
  • Component changed from PLEASE CHANGE to python3
  • Status changed from new to needs_review

easy little ticket


New commits:

700320econvert one comparison to use key (in matrix2)

comment:2 Changed 5 years ago by aapitzsch

  • Reviewers set to André Apitzsch
  • Status changed from needs_review to positive_review
  • Type changed from PLEASE CHANGE to enhancement

I think it doesn't matter whether it's list.sort(v) or v.sort(); that's why positive review.

comment:3 Changed 5 years ago by vbraun

  • Branch changed from public/21414 to 700320e17544b36ef34f0212fad9b825450fa646
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.