Opened 5 years ago

Closed 5 years ago

#21411 closed defect (fixed)

New numerical noise in symbolic/function.pyx

Reported by: leif Owned by:
Priority: trivial Milestone: sage-7.4
Component: fast_callable Keywords: doctest error, erf, fast_eval, tolerance, precision
Cc: Merged in:
Authors: Leif Leonhardy Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: 2568583 (Commits, GitHub, GitLab) Commit: 25685837f4d5d56dcb1d70a18d000f2b7348ab13
Dependencies: Stopgaps:

Status badges

Description

Popped up in Sage 7.4.beta2 (or probably some earlier beta): 

----------------------------------------------------------------------
sage -t --long src/sage/libs/gap/assigned_names.py  # 1 doctest failed
sage -t --long src/sage/symbolic/function.pyx  # 1 doctest failed
----------------------------------------------------------------------

The first is the usual failure, the second is new, and I don't know
where it originates from (as the doctest itself hasn't changed):

**********************************************************************
File "src/sage/symbolic/function.pyx", line 667, in
sage.symbolic.function.Function._fast_float_
Failed example:
    ff(1.5)
Expected:
    0.9661051464753108
Got:
    0.9661051464753109
**********************************************************************

(Native build on Haswell.)

Change History (3)

comment:1 Changed 5 years ago by leif

  • Authors set to Leif Leonhardy
  • Branch set to u/leif/new_noise_in_symbolic/function.pyx
  • Commit set to 25685837f4d5d56dcb1d70a18d000f2b7348ab13
  • Status changed from new to needs_review

New commits:

​2568583Trac #21411: Fix numerical noise by adding tolerance to one example.

comment:2 Changed 5 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:3 Changed 5 years ago by vbraun

  • Branch changed from u/leif/new_noise_in_symbolic/function.pyx to 25685837f4d5d56dcb1d70a18d000f2b7348ab13
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.