Opened 3 years ago

Closed 3 years ago

#21390 closed enhancement (fixed)

Error reporting for is_cartesian_product(DiGraph)

Reported by: jmantysalo Owned by:
Priority: minor Milestone: sage-7.4
Component: graph theory Keywords:
Cc: chapoton Merged in:
Authors: Jori Mäntysalo Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 2ebacfd (Commits) Commit: 2ebacfd9bedb0bb6a20ab2930149519aafad0fe4
Dependencies: Stopgaps:

Description (last modified by jmantysalo)

This is irritating:

sage: from sage.graphs.graph_decompositions.graph_products import is_cartesian_product
sage: G = DiGraph({0:[1,2,3]})
sage: is_cartesian_product(G)
Traceback (click to the left of this block for traceback)
...
KeyError: 2

Change History (4)

comment:1 Changed 3 years ago by jmantysalo

  • Branch set to u/jmantysalo/digraph-is-cartesian

comment:2 Changed 3 years ago by jmantysalo

  • Cc chapoton added
  • Commit set to 2ebacfd9bedb0bb6a20ab2930149519aafad0fe4
  • Description modified (diff)
  • Status changed from new to needs_review

This should be implemented, but now it at least gives meaningfull error.


New commits:

2ebacfdAdd better error reporting.

comment:3 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

comment:4 Changed 3 years ago by vbraun

  • Branch changed from u/jmantysalo/digraph-is-cartesian to 2ebacfd9bedb0bb6a20ab2930149519aafad0fe4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.