Opened 3 years ago

Closed 3 years ago

#21374 closed enhancement (fixed)

py3 get rid of izip

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.4
Component: python3 Keywords:
Cc: tscrim, jdemeyer, aapitzsch, jmantysalo Merged in:
Authors: Frédéric Chapoton Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: 747e784 (Commits) Commit: 747e784470f69c429968ef7f415115676e55b23c
Dependencies: Stopgaps:

Description

similar to #21364

instead of itertools.izip, let us use builtins.zip

Change History (6)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/21374
  • Commit set to 747e784470f69c429968ef7f415115676e55b23c
  • Status changed from new to needs_review

New commits:

747e784get rid of izip (step 1/1)

comment:2 Changed 3 years ago by chapoton

  • Cc tscrim jdemeyer aapitzsch jmantysalo added

bot is green

comment:3 Changed 3 years ago by aapitzsch

Usage of list in
zipped_coords = list(zip(*self)) in src/sage/combinat/tiling.py and in
Slist = list(zip([g.ideal() for g in C.gens()], C.invariants())) in src/sage/rings/number_field/number_field.py seems unnecessary.

comment:4 follow-up: Changed 3 years ago by chapoton

In both cases, it is necessary, because one can use an iterator only once. And we need it twice.

comment:5 in reply to: ↑ 4 Changed 3 years ago by aapitzsch

  • Reviewers set to André Apitzsch
  • Status changed from needs_review to positive_review

Replying to chapoton:

In both cases, it is necessary, because one can use an iterator only once. And we need it twice.

Okay.

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/21374 to 747e784470f69c429968ef7f415115676e55b23c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.