Opened 3 years ago

Closed 3 years ago

#21371 closed enhancement (fixed)

Clean up pynac interface

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.4
Component: interfaces Keywords:
Cc: rws Merged in:
Authors: Jeroen Demeyer Reviewers: Ralf Stephan
Report Upstream: N/A Work issues:
Branch: ab394a2 (Commits) Commit: ab394a219b914d987ee96d21ea10ee27a8315c15
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

Clean up Pynac interface in src/sage/libs/pynac:

  1. A lot of functions have except + but don't have any C++ code so they cannot possibly raise C++ exceptions.
  1. Drop all useless object typing.
  1. Correctly declare C++ classes as cppclass instead of struct.
  1. Move the Some tests for the formal square root of -1. in pynac.pyx to a real docstring.
  1. Use parent() instead of the deprecated parent_c().
  1. Move all imports together instead of scattering them throughout pynac.pyx.

Change History (16)

comment:1 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 3 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Clean up pynac.pyx to Clean up pynac interface

comment:3 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:4 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:7 Changed 3 years ago by jdemeyer

  • Dependencies set to #21369

comment:8 Changed 3 years ago by jdemeyer

  • Dependencies changed from #21369 to #21372
  • Description modified (diff)

comment:9 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:10 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:11 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:12 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:13 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/clean_up_pynac_interface

comment:14 Changed 3 years ago by jdemeyer

  • Commit set to ab394a219b914d987ee96d21ea10ee27a8315c15
  • Dependencies #21372 deleted
  • Status changed from new to needs_review

New commits:

ab394a2Clean up pynac interface

comment:15 Changed 3 years ago by rws

  • Reviewers set to Ralf Stephan
  • Status changed from needs_review to positive_review

Much appreciated. Passes tests in all relevant directories.

comment:16 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/clean_up_pynac_interface to ab394a219b914d987ee96d21ea10ee27a8315c15
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.