Opened 3 years ago

Closed 3 years ago

#21364 closed enhancement (fixed)

py3: get rid of imap

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.4
Component: python3 Keywords:
Cc: tscrim, jdemeyer, aapitzsch Merged in:
Authors: Frédéric Chapoton Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: ad15cf3 (Commits) Commit: ad15cf38cd8339d758743e5e964eaaebbbaec41b
Dependencies: Stopgaps:

Description

instead of itertools.imap, let us use builtins.map

Change History (6)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/21364
  • Cc tscrim jdemeyer aapitzsch added
  • Commit set to 035d41794085e5ca4095ae6b962d7fef8c8cf5f9
  • Status changed from new to needs_review

New commits:

​035d417trac 21364 get rid of imap

comment:2 Changed 3 years ago by aapitzsch

  • Reviewers set to André Apitzsch

I would suggest to mention only ``map`` from the Python module ``builtins`` in src/sage/groups/perm_gps/symgp_conjugacy_class.py.

But it's fine anyway. This can be set to positive review if patchbot doesn't complain.

comment:3 Changed 3 years ago by git

  • Commit changed from 035d41794085e5ca4095ae6b962d7fef8c8cf5f9 to ad15cf38cd8339d758743e5e964eaaebbbaec41b

Branch pushed to git repo; I updated commit sha1. New commits:

​ad15cf3trac 21364 detail

comment:4 Changed 3 years ago by chapoton

waiting for the bot

for another ticket: there remains a few "itertools.imap"

comment:5 Changed 3 years ago by chapoton

  • Status changed from needs_review to positive_review

ok, bot is happy (problem in tutte is not related)

thanks for the review

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/21364 to ad15cf38cd8339d758743e5e964eaaebbbaec41b
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.