Opened 2 years ago

Closed 2 years ago

#21332 closed enhancement (fixed)

Creation of a method 'canonicalize_radical' for symbolic matrices

Reported by: fdosso48 Owned by:
Priority: major Milestone: sage-7.4
Component: linear algebra Keywords: sd75
Cc: Merged in:
Authors: Fangan Dosso Reviewers: Travis Scrimshaw, Thierry Monteil
Report Upstream: N/A Work issues:
Branch: 29d6519 (Commits) Commit: 29d6519e1fd23fe08a7128179c27dbb43ad29f2f
Dependencies: Stopgaps:

Description (last modified by tmonteil)

There is a method 'canonicalize_radical' for symbolic expressions and symbolic vectors but not for symbolic matrices. The goal of this ticket is to create one for matrices.

This feature was requested on this ask question.

Change History (9)

comment:1 Changed 2 years ago by fdosso48

  • Branch set to u/fdosso48/canonicalize_radical_matrice

comment:2 Changed 2 years ago by fdosso48

  • Commit set to 7b1b3ec5b6042c57a1d1af4d17e8c081b900572f
  • Component changed from PLEASE CHANGE to linear algebra

comment:3 Changed 2 years ago by fdosso48

  • Keywords sd75 added

comment:4 Changed 2 years ago by git

  • Commit changed from 7b1b3ec5b6042c57a1d1af4d17e8c081b900572f to 01931f3e0af227315e027e2089d27bad594f65ed

Branch pushed to git repo; I updated commit sha1. New commits:

01931f3adds a method called 'canonicalize_radical'

comment:5 Changed 2 years ago by fdosso48

  • Status changed from new to needs_review

comment:6 Changed 2 years ago by git

  • Commit changed from 01931f3e0af227315e027e2089d27bad594f65ed to 29d6519e1fd23fe08a7128179c27dbb43ad29f2f

Branch pushed to git repo; I updated commit sha1. New commits:

29d6519updates 'canonicalize_radical' method documentation

comment:7 Changed 2 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review
  • Type changed from task to enhancement

This will work for now, but I think a better long-term solution would be to mimic what symbolic vectors do (i.e., not have individual methods with doctests), possibly having a mixin class that abstracts that behavior.

comment:8 Changed 2 years ago by tmonteil

  • Description modified (diff)
  • Reviewers changed from Travis Scrimshaw to Travis Scrimshaw, Thierry Monteil
  • Summary changed from Creation of a method 'canonicalize_radical' for matrices to Creation of a method 'canonicalize_radical' for symbolic matrices

comment:9 Changed 2 years ago by vbraun

  • Branch changed from u/fdosso48/canonicalize_radical_matrice to 29d6519e1fd23fe08a7128179c27dbb43ad29f2f
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.