Opened 6 years ago

Closed 6 years ago

#21329 closed enhancement (fixed)

add documentation to exhibit colored revolution plot3d

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.4
Component: graphics Keywords:
Cc: was, kcrisman, paulmasson Merged in:
Authors: Frédéric Chapoton Reviewers: Paul Masson
Report Upstream: N/A Work issues:
Branch: 29ef788 (Commits, GitHub, GitLab) Commit: 29ef788445307b1ef30ebce7e1280310a3f35358
Dependencies: Stopgaps:

Status badges

Description

This works, and nobody knows..

Let us give a simple example.

I have also cleaned up the code (just some pep8 changes)

Change History (9)

comment:1 Changed 6 years ago by chapoton

  • Branch set to u/chapoton/21329
  • Cc was kcrisman added
  • Commit set to 33f59fac8be8d31f19166d83ccb90db09133d927
  • Status changed from new to needs_review

New commits:

33f59fadocument the (colorfun,colormap) option for plot3d of revolution surfaces

comment:2 Changed 6 years ago by git

  • Commit changed from 33f59fac8be8d31f19166d83ccb90db09133d927 to 620aa05b0d5e73b1fa894f9f2602e7647a019bf8

Branch pushed to git repo; I updated commit sha1. New commits:

620aa05trac 21329 oops, wrong isinstance call

comment:3 Changed 6 years ago by tscrim

  • Cc paulmasson added

comment:4 Changed 6 years ago by paulmasson

  • Reviewers set to Paul Masson

Doctests pass, documentation builds. Code cleanup looks good.

The new example looks nice, but why the tachyon viewer?

comment:5 Changed 6 years ago by chapoton

well, why not ? do you want me to remove the viewer="tachyon" ?

comment:6 Changed 6 years ago by paulmasson

Yes please. I find it preferable that 3D examples use the best possible viewer available to the system.

Positive review after that. Thanks!

comment:7 Changed 6 years ago by git

  • Commit changed from 620aa05b0d5e73b1fa894f9f2602e7647a019bf8 to 29ef788445307b1ef30ebce7e1280310a3f35358

Branch pushed to git repo; I updated commit sha1. New commits:

29ef788trac 21329 not using viewer=tachyon, plus added a little warning

comment:8 Changed 6 years ago by chapoton

  • Status changed from needs_review to positive_review

done, and thanks for the review !

comment:9 Changed 6 years ago by vbraun

  • Branch changed from u/chapoton/21329 to 29ef788445307b1ef30ebce7e1280310a3f35358
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.