Opened 3 years ago

Closed 3 years ago

#21320 closed enhancement (fixed)

py3: remove itervalues outside of combinat folder

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.4
Component: python3 Keywords:
Cc: tscrim, jmantysalo, jdemeyer Merged in:
Authors: Frédéric Chapoton Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: 78b3c9c (Commits) Commit: 78b3c9cad0c11f3f04d2259d02b2cc55e6fe67af
Dependencies: Stopgaps:

Description

sequel to #21310

remove use of .itervalues, using six

here, everywhere not in combinat folder

Change History (6)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/21320
  • Cc tscrim jmantysalo jdemeyer added
  • Commit set to 9ee161af9b6bd822aaf1816267580ffda1e55d90
  • Status changed from new to needs_review

New commits:

9ee161aget rid of itervalues outside of combinat

comment:2 Changed 3 years ago by git

  • Commit changed from 9ee161af9b6bd822aaf1816267580ffda1e55d90 to 78b3c9cad0c11f3f04d2259d02b2cc55e6fe67af

Branch pushed to git repo; I updated commit sha1. New commits:

78b3c9cMerge branch 'u/chapoton/21320' in 7.4.b2

comment:3 Changed 3 years ago by chapoton

ping ?

comment:4 follow-up: Changed 3 years ago by jmantysalo

  • Reviewers set to Jori Mäntysalo

I can take this one. Will take some time.

comment:5 in reply to: ↑ 4 Changed 3 years ago by jmantysalo

  • Status changed from needs_review to positive_review

Replying to jmantysalo:

Will take some time.

Wasn't so long. LGTM.

comment:6 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/21320 to 78b3c9cad0c11f3f04d2259d02b2cc55e6fe67af
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.