Opened 3 years ago

Last modified 4 months ago

#21319 needs_review enhancement

recognizable series: hash, comparison, TestSuite

Reported by: dkrenn Owned by:
Priority: major Milestone: sage-7.4
Component: combinatorics Keywords:
Cc: Merged in:
Authors: Daniel Krenn Reviewers:
Report Upstream: N/A Work issues:
Branch: u/dkrenn/sequences/rec-hash (Commits) Commit: a87520e77b600601c85cdd86540cec89ef411ad0
Dependencies: #21325, #21336 Stopgaps:

Description (last modified by dkrenn)

  • Implement hashing and comparison.
  • Make TestSuite? pass all tests.

See also meta ticket #21202.

Change History (19)

comment:1 Changed 3 years ago by dkrenn

  • Dependencies set to #21318
  • Description modified (diff)

comment:2 Changed 3 years ago by dkrenn

  • Branch set to u/dkrenn/sequences/rec-basic-arith

comment:3 Changed 3 years ago by dkrenn

  • Branch u/dkrenn/sequences/rec-basic-arith deleted

comment:4 Changed 3 years ago by dkrenn

  • Branch set to u/dkrenn/sequences/rec-hash

comment:5 Changed 3 years ago by git

  • Commit set to ffe5f906f2d21558096a59a24297e4efaacb0f75

Branch pushed to git repo; I updated commit sha1. New commits:

01495cbextend to negative shifts in subsequence
b76bf4efactor out subsequence to separat ticket
5919120doctesting all parameters in coefficient_of_word
c7243a6Merge tag '7.4.beta1' into t/21295/sequences/recognizable
4012778Merge branch 't/21295/sequences/recognizable' into t/21203/sequences/k-regular
5dbedabfix doctests (experimental warning)
143ea73fix building of docs (no idea why it failed)
6247a7fMerge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
ffe5f90Merge branch 't/21318/sequences/rec-basic-arith' into t/21319/sequences/rec-hash

comment:6 Changed 3 years ago by git

  • Commit changed from ffe5f906f2d21558096a59a24297e4efaacb0f75 to a4ccbec7d2d16f43342bb44a7fc756bf7d448081

Branch pushed to git repo; I updated commit sha1. New commits:

a8e6334MatrixSpace.some_elements
520aaf1FreeModule_generic.some_elements
5afda8eMerge branch 'u/dkrenn/matrices-some-elements' into t/21319/sequences/rec-hash
1e5754ban_element and some_elements
becce48pickling support
a4ccbecTestSuite

comment:7 Changed 3 years ago by dkrenn

  • Description modified (diff)
  • Status changed from new to needs_review
  • Summary changed from recognizable series: hash, comparison to recognizable series: hash, comparison, TestSuite

comment:8 Changed 3 years ago by dkrenn

  • Dependencies changed from #21318 to #21318, #21336

comment:9 Changed 3 years ago by git

  • Commit changed from a4ccbec7d2d16f43342bb44a7fc756bf7d448081 to c2f9c628bdd78c89a3d8235a8a3424c0f6769c81

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

41bc288quasi-cherry-pick of pad_right of k-regular-guess branch
3023233rewrite to make subsequence more efficient (dynamically add kernel)
51e7d72minor rewrite
9311636allow b to be a dict
624e6c0forward/backward difference
45d9e67minor rewrites
c430158partial sums
7eb93e1minor rewrites to use existing stuff better
0f89159Merge branch 't/21318/sequences/rec-basic-arith' into t/21325/sequences/k-regular-subseq
c2f9c62Merge branch 't/21325/sequences/k-regular-subseq' into t/21319/sequences/rec-hash

comment:10 Changed 3 years ago by dkrenn

  • Dependencies changed from #21318, #21336 to #21318, #21325, #21336

Merged #21325 to avoid a (trivial) merge conflict.

comment:11 Changed 3 years ago by git

  • Commit changed from c2f9c628bdd78c89a3d8235a8a3424c0f6769c81 to c8a86dbf1eddf7e6205e38ae5e037c8944aab5a0

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

e03a32fMerge tag '7.4.beta2' into t/21180/cantor_product_comb
642cceeMerge branch 't/21180/cantor_product_comb' into t/21203/sequences/k-regular
352751eMerge tag '7.4.beta2' into t/21295/sequences/recognizable
914640fMerge branch 't/21295/sequences/recognizable' into t/21203/sequences/k-regular
c0ade99Merge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
35807dfMerge branch 't/21318/sequences/rec-basic-arith' into t/21319/sequences/rec-hash
a2fe6f3Merge branch 't/21318/sequences/rec-basic-arith' into t/21325/sequences/k-regular-subseq
e4cec17minor correction in doc
3a4e849Merge branch 't/21318/sequences/rec-basic-arith' into t/21325/sequences/k-regular-subseq
c8a86dbMerge branch 't/21325/sequences/k-regular-subseq' into t/21319/sequences/rec-hash

comment:12 Changed 3 years ago by git

  • Commit changed from c8a86dbf1eddf7e6205e38ae5e037c8944aab5a0 to 18c52684895620e08e00fbc49eca28fbf0659179

Branch pushed to git repo; I updated commit sha1. New commits:

18c5268correct typo in docstring

comment:13 follow-up: Changed 3 years ago by cheuberg

  • Status changed from needs_review to needs_work

doctest failures (cf. patchbot), patchbot python3 warning.

comment:14 Changed 2 years ago by git

  • Commit changed from 18c52684895620e08e00fbc49eca28fbf0659179 to fcb53a3611e27f8f87684af842cc30f07e43d94b

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

4970cf5Python3: absolute import
e33a3c9Merge branch 't/21295/sequences/recognizable' into t/21203/sequences/k-regular
4da9796Merge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
13b536ePython3: absolut import
5919c4dMerge branch 't/21203/sequences/k-regular' into t/21318/sequences/rec-basic-arith
9086b64Merge branch 't/21318/sequences/rec-basic-arith' into t/21325/sequences/k-regular-subseq
fc6c3f5Python3: xrange
714276cMerge branch 't/21325/sequences/k-regular-subseq' into t/21319/sequences/rec-hash
457aefdPython3: fix iteritems
fcb53a3fix doctest output of TestSuite (new tests were added)

comment:15 Changed 2 years ago by dkrenn

  • Description modified (diff)
  • Status changed from needs_work to needs_review

comment:16 in reply to: ↑ 13 Changed 2 years ago by dkrenn

Replying to cheuberg:

doctest failures (cf. patchbot), patchbot python3 warning.

Fixed.

comment:17 Changed 16 months ago by dkrenn

  • Dependencies changed from #21318, #21325, #21336 to #21325, #21336

comment:18 Changed 16 months ago by git

  • Commit changed from fcb53a3611e27f8f87684af842cc30f07e43d94b to e30a7fb00b10f9d6a1eafb4a606bf844b832a8f3

Branch pushed to git repo; I updated commit sha1. New commits:

c2bf1b8Merge tag '8.1' into u/dkrenn/sequences/recognizable
fef79b2Merge branch 'u/dkrenn/sequences/recognizable' into u/dkrenn/sequences/k-regular
8eda76eMerge branch 'u/dkrenn/sequences/k-regular' into u/dkrenn/sequences/rec-basic-arith
0c83557Merge branch 'u/dkrenn/sequences/rec-basic-arith' into u/dkrenn/sequences/k-regular-subseq
e30a7fbMerge branch 'u/dkrenn/sequences/k-regular-subseq' into u/dkrenn/sequences/rec-hash

comment:19 Changed 4 months ago by git

  • Commit changed from e30a7fb00b10f9d6a1eafb4a606bf844b832a8f3 to a87520e77b600601c85cdd86540cec89ef411ad0

Branch pushed to git repo; I updated commit sha1. New commits:

5dbdcbbMerge tag '8.7' into u/dkrenn/sequences/recognizable
d17def8Merge branch 'u/dkrenn/sequences/recognizable' into u/dkrenn/sequences/k-regular
2b998baMerge branch 'u/dkrenn/sequences/k-regular' into u/dkrenn/sequences/rec-basic-arith
1f8c2a1Merge branch 'u/dkrenn/sequences/rec-basic-arith' into u/dkrenn/sequences/k-regular-subseq
a87520eMerge branch 'u/dkrenn/sequences/k-regular-subseq' into u/dkrenn/sequences/rec-hash
Note: See TracTickets for help on using tickets.