Opened 4 years ago

Closed 4 years ago

#21311 closed enhancement (fixed)

Improving documentation of _breadth_first_search_iterator_from_graded…

Reported by: slabbe Owned by:
Priority: major Milestone: sage-7.4
Component: combinatorics Keywords:
Cc: Merged in:
Authors: Sébastien Labbé Reviewers: Salvatore Stella
Report Upstream: N/A Work issues:
Branch: e7fe7bf (Commits) Commit: e7fe7bf1298e481b1581c17ae0eefaf5e30f008c
Dependencies: Stopgaps:

Description

While looking at this file on github, I realised the documentation of one method was not perfect. I edited the documentation directly on github and created a pull request:

https://github.com/sagemath/sage/pull/63

Change History (6)

comment:1 Changed 4 years ago by slabbe

  • Status changed from new to needs_review

What is the procedure github pull request? Should I create a branch?

comment:2 Changed 4 years ago by etn40ff

I am not sure pull-requests in github are acceptable

comment:3 Changed 4 years ago by slabbe

  • Branch set to u/slabbe/21311
  • Commit set to e7fe7bf1298e481b1581c17ae0eefaf5e30f008c

I wasn't sure and I wanted to test that option. For just editing documentation, it seems desirable.

I just redone the changes as a branch.


New commits:

e7fe7bf21311: improving doc

comment:4 Changed 4 years ago by etn40ff

  • Reviewers set to Salvatore Stella
  • Status changed from needs_review to positive_review

comment:5 Changed 4 years ago by slabbe

  • Authors set to Sébastien Labbé

Thanks for the review.

comment:6 Changed 4 years ago by vbraun

  • Branch changed from u/slabbe/21311 to e7fe7bf1298e481b1581c17ae0eefaf5e30f008c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.