Opened 4 years ago

Last modified 17 months ago

#21309 closed enhancement

Package thebe.js — at Version 6

Reported by: tmonteil Owned by:
Priority: major Milestone: sage-7.5
Component: packages: standard Keywords: sd75, sdl
Cc: fcayre, vdelecroix, nthiery, slelievre Merged in:
Authors: Thierry Monteil Reviewers: Nicolas M. Thiéry
Report Upstream: N/A Work issues:
Branch: u/nthiery/package_thebe_js (Commits) Commit: e1b914a7ec935bd6fadb8eb1cd8f6ced77b26bd5
Dependencies: Stopgaps:

Description (last modified by nthiery)

With the first implementation of #20690, thebe.js was entangled within Sage source code. Since upstream is well defined, the aim of this ticket is to package it the usual way. #20690 is now based on it.

The zipball can be found at https://github.com/oreillymedia/thebe/archive/master.zip and should be renamed thebejs-20160822.zip (upstream does not propose explicit releases).

It can also temporarly be downloaded at https://lipn.univ-paris13.fr/~monteil/hebergement/tmp/thebejs-20160822.zip

Change History (6)

comment:1 Changed 4 years ago by tmonteil

  • Branch set to u/tmonteil/package_thebe_js

comment:2 Changed 4 years ago by tmonteil

  • Cc fcayre vdelecroix nthiery slelievre added
  • Commit set to 7d4fe864b00482ed97a0fc1f98a8150e5c83fc84
  • Status changed from new to needs_review

New commits:

7d4fe86#21309 : package thebejs.

comment:3 Changed 4 years ago by tmonteil

  • Keywords sd75 added

comment:4 Changed 4 years ago by nthiery

  • Branch changed from u/tmonteil/package_thebe_js to u/nthiery/package_thebe_js

comment:5 Changed 4 years ago by git

  • Commit changed from 7d4fe864b00482ed97a0fc1f98a8150e5c83fc84 to e1b914a7ec935bd6fadb8eb1cd8f6ced77b26bd5

Branch pushed to git repo; I updated commit sha1. New commits:

e1b914a21309: made the instructions to fetch the latest thebe version into an executable shell command

comment:6 Changed 4 years ago by nthiery

  • Description modified (diff)
  • Reviewers set to Nicolas M. Thiéry
  • Status changed from needs_review to positive_review

We discussed this face to face with Thierry, and I made minor improvements to the text in the SPKG that he double checked over my shoulder. The files look good. I tested it, and it works.

Positive review. Thanks Thierry!

Note: See TracTickets for help on using tickets.