Package thebe.js

[tmonteil]

With the first implementation of #20690, thebe.js was entangled within Sage source code. Since upstream is well defined, the aim of this ticket is to package it the usual way. #20690 is now based on it.

The zipball can be found at ​https://github.com/oreillymedia/thebe/archive/9624e0a07a00026103dce1a3e32bbfbf90a6d0f9.zip and should be renamed thebe-9624e0a0.zip (upstream does not propose explicit releases).

It can also temporarly be downloaded at ​https://lipn.univ-paris13.fr/~monteil/hebergement/tmp/thebe-9624e0a0.zip

[tmonteil]

New commits:

​7d4fe86

#21309 : package thebejs.

[git]

Branch pushed to git repo; I updated commit sha1. New commits:

​e1b914a

21309: made the instructions to fetch the latest thebe version into an executable shell command

[nthiery]

We discussed this face to face with Thierry, and I made minor improvements to the text in the SPKG that he double checked over my shoulder. The files look good. I tested it, and it works.

Positive review. Thanks Thierry!

[fbissey]

I personally would have preferred a spkg-src that pulls a given git commit. Downloading master.zip is quite likely not a repeatable operation (as in "it doesn't necessarily give you the same file every time").

[tmonteil]

Would downloading thebe-9624e0a07a00026103dce1a3e32bbfbf90a6d0f9.zip instead of master.zip be satisfying ?

[fbissey]

It would probably work :)

[tmonteil]

OK i have done that. The hash of the zipball changed, but according to dirdiff the content is the same.

---

New commits:

​8af8f5e

#21309 : fetch the archive named by the commit of the master branch.

[tmonteil]

Is it satisfactory like this ?

[jdemeyer]

You should have the git commit in the version number. It should be possible to exactly reconstruct the tarball. The date on which it was packaged is not sufficient for that.

When you do this, also adjust the instructions in SPKG.txt (and perhaps replace #20690 by the actual Trac URL).

[jdemeyer]

Also: upstream calls itself thebe, why rename to thebejs?

[nthiery]

Hi Thierry! Just to avoid duplicated work: have you started implementing Jeroen's comments? otherwise I can have a go tomorrow morning with him.

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​520cdd0

#21309 : thebejs -> thebe ; use hash in pkg name ; link to trac URL.

[tmonteil]

Replying to jdemeyer:

You should have the git commit in the version number. It should be possible to exactly reconstruct the tarball. The date on which it was packaged is not sufficient for that.

Done.

When you do this, also adjust the instructions in SPKG.txt (and perhaps replace #20690 by the actual Trac URL).

Done.

Replying to jdemeyer:

Also: upstream calls itself thebe, why rename to thebejs?

Most javascript libs have dual names, for example node vs nodejs or d3 vs d3js. Since we used the *js name for in other packages, i took that one, but indeed, in the case of thebe there is no *js version. So i renamed the package thebeas suggested.