#21296 closed enhancement (fixed)
get rid of some useless .keys
Reported by: | chapoton | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-7.4 |
Component: | python3 | Keywords: | |
Cc: | jmantysalo, tscrim, aapitzsch | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Jeroen Demeyer |
Report Upstream: | N/A | Work issues: | |
Branch: | 45377ee (Commits) | Commit: | |
Dependencies: | Stopgaps: |
Description
with an eye towards python3 compatibility
when iterating over a dict, one does not need to call .keys()
and when asking for the list of keys, it is better to call list(d) for compatibility with py3
Removing .keys() when possible is performed in some files, not everywhere.
Change History (5)
comment:1 Changed 3 years ago by
- Branch set to u/chapoton/21296
- Commit set to 45377eecadf076cf5bb0dc771f37250611a6c41e
- Status changed from new to needs_review
comment:2 Changed 3 years ago by
- Cc jmantysalo tscrim aapitzsch added
patchbot is green (except for a timeout problem in Tutte polynomials which happens for every ticket on this patchbot)
comment:3 Changed 3 years ago by
- Reviewers set to Jeroen Demeyer
- Status changed from needs_review to positive_review
comment:4 Changed 3 years ago by
- Branch changed from u/chapoton/21296 to 45377eecadf076cf5bb0dc771f37250611a6c41e
- Resolution set to fixed
- Status changed from positive_review to closed
comment:5 Changed 3 years ago by
- Commit 45377eecadf076cf5bb0dc771f37250611a6c41e deleted
sequel in #21304
Note: See
TracTickets for help on using
tickets.
New commits:
getting rid of some useless .keys()