Opened 6 years ago

Closed 6 years ago

#21288 closed defect (fixed)

Add package version check to OptionalExtension

Reported by: jdemeyer Owned by:
Priority: blocker Milestone: sage-7.4
Component: build Keywords:
Cc: chapoton Merged in:
Authors: Jeroen Demeyer Reviewers: Matthias Koeppe
Report Upstream: N/A Work issues:
Branch: 9ceab13 (Commits, GitHub, GitLab) Commit: 9ceab139109747004dea9d7f01373df5ee34c1c4
Dependencies: Stopgaps:

Status badges

Description

The logic for OptionalExtension only checks whether some version of the package is installed, which might not be the latest version. This problem is causing failures with bliss on the sage4 patchbot.

Change History (4)

comment:1 Changed 6 years ago by jdemeyer

Branch: → u/jdemeyer/add_package_version_check_to_optionalextension

comment:2 Changed 6 years ago by jdemeyer

Authors: → Jeroen Demeyer
Commit: → 9ceab139109747004dea9d7f01373df5ee34c1c4
Status: new → needs_review

New commits:

​9ceab13Add package version check to OptionalExtension

comment:3 Changed 6 years ago by mkoeppe

Reviewers: → Matthias Koeppe
Status: needs_review → positive_review

This seems to work fine. I'd guess a more distribution-friendly way would be to use proper tests, like configure scripts do, for existing libraries/headers, instead of relying on package versions. #20382 seems to go in this direction.

Last edited 6 years ago by mkoeppe (previous) (diff)

comment:4 Changed 6 years ago by vbraun

Branch: u/jdemeyer/add_package_version_check_to_optionalextension → 9ceab139109747004dea9d7f01373df5ee34c1c4
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.