Opened 3 years ago

Closed 3 years ago

#21261 closed enhancement (fixed)

Add entrypoints and configparser packages

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-7.4
Component: packages: standard Keywords:
Cc: embray Merged in:
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: Reported upstream. Developers deny it's a bug. Work issues:
Branch: fdb403e (Commits) Commit: fdb403eb74130532900c41e73c54e5de8fb441d0
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

entrypoints is officially a dependency of the Jupyter nbconvert module, so Sage should also have it.

This distribution is missing a setup.py (upstream denies this is a bug), so we provide one within Sage.

configparser is a dependency of entrypoints.

Tarballs:

Change History (12)

comment:1 Changed 3 years ago by jdemeyer

This is a very strange package, it doesn't even have setup.py...

comment:2 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:3 Changed 3 years ago by jdemeyer

  • Description modified (diff)
  • Report Upstream changed from N/A to Reported upstream. Developers deny it's a bug.

comment:4 Changed 3 years ago by embray

Yeah I'm not crazy about flit in part because it doesn't provide any backwards-compatibility.

comment:5 Changed 3 years ago by embray

I think a better thing to do would be to just pip install the wheel directly, though that would mean adding support for wheels as upstream packages (not a bad idea IMO).

comment:6 Changed 3 years ago by embray

If I'd seen this sooner I coulda saved you the time of submitting the issue. This is what I've been saying all along--setup.py is going away, eventually. This is an example of being a bit overly aggressive about it I think but it's not wrong either.

comment:7 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:8 Changed 3 years ago by jdemeyer

  • Description modified (diff)
  • Summary changed from Add a entrypoints package to Add entrypoints and configparser packages

comment:9 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/add_a_entrypoints_package

comment:10 Changed 3 years ago by jdemeyer

  • Commit set to fdb403eb74130532900c41e73c54e5de8fb441d0
  • Status changed from new to needs_review

New commits:

fdb403eAdd entrypoints and configparser packages

comment:11 Changed 3 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

comment:12 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/add_a_entrypoints_package to fdb403eb74130532900c41e73c54e5de8fb441d0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.