Opened 5 years ago

Closed 5 years ago

#21253 closed enhancement (fixed)

LatticePoset: is_complemented() with certificate

Reported by: jmantysalo Owned by:
Priority: major Milestone: sage-7.4
Component: combinatorics Keywords:
Cc: Merged in:
Authors: Jori Mäntysalo Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 5888a66 (Commits, GitHub, GitLab) Commit: 5888a667a6a29e4b00f888a38a5bedbf5a575312
Dependencies: Stopgaps:

Status badges

Description

This patch will add a certificate-option to is_complemented(); compare to is_sectionally_complemented() and is_relatively_complemented().

At the same time this drops computation time. As an example after meets and joins are computed for TamariLattice(7) it took 140 ms to check that it is complemented; with this patch it is about 85 ms. It is also faster when filtering complemented lattices from all 10-element lattices.

Change History (6)

comment:1 Changed 5 years ago by jmantysalo

  • Branch set to u/jmantysalo/is-complemented

comment:2 Changed 5 years ago by jmantysalo

  • Commit set to f09dd88e7410e45941648b6db4841666d9b94cd5
  • Status changed from new to needs_review

New commits:

f09dd88Add certificate to is_complemented().

comment:3 follow-up: Changed 5 years ago by chapoton

  • Branch changed from u/jmantysalo/is-complemented to public/21253
  • Commit changed from f09dd88e7410e45941648b6db4841666d9b94cd5 to 5888a667a6a29e4b00f888a38a5bedbf5a575312

Looks good. I have just made a pep8 reviewer's commit. You can set to positive review if you agree with my cosmetic changes.


New commits:

5888a66trac 21253 reviewer's commit (pep8 only)

comment:4 Changed 5 years ago by chapoton

  • Reviewers set to Frédéric Chapoton

comment:5 in reply to: ↑ 3 Changed 5 years ago by jmantysalo

  • Status changed from needs_review to positive_review

Replying to chapoton:

You can set to positive review if you agree with my cosmetic changes.

I agree. Thanks.

comment:6 Changed 5 years ago by vbraun

  • Branch changed from public/21253 to 5888a667a6a29e4b00f888a38a5bedbf5a575312
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.