Opened 6 years ago

Closed 6 years ago

#21253 closed enhancement (fixed)

LatticePoset: is_complemented() with certificate

Reported by: Jori Mäntysalo Owned by:
Priority: major Milestone: sage-7.4
Component: combinatorics Keywords:
Cc: Merged in:
Authors: Jori Mäntysalo Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 5888a66 (Commits, GitHub, GitLab) Commit: 5888a667a6a29e4b00f888a38a5bedbf5a575312
Dependencies: Stopgaps:

Status badges

Description

This patch will add a certificate-option to is_complemented(); compare to is_sectionally_complemented() and is_relatively_complemented().

At the same time this drops computation time. As an example after meets and joins are computed for TamariLattice(7) it took 140 ms to check that it is complemented; with this patch it is about 85 ms. It is also faster when filtering complemented lattices from all 10-element lattices.

Change History (6)

comment:1 Changed 6 years ago by Jori Mäntysalo

Branch: u/jmantysalo/is-complemented

comment:2 Changed 6 years ago by Jori Mäntysalo

Commit: f09dd88e7410e45941648b6db4841666d9b94cd5
Status: newneeds_review

New commits:

f09dd88Add certificate to is_complemented().

comment:3 Changed 6 years ago by Frédéric Chapoton

Branch: u/jmantysalo/is-complementedpublic/21253
Commit: f09dd88e7410e45941648b6db4841666d9b94cd55888a667a6a29e4b00f888a38a5bedbf5a575312

Looks good. I have just made a pep8 reviewer's commit. You can set to positive review if you agree with my cosmetic changes.


New commits:

5888a66trac 21253 reviewer's commit (pep8 only)

comment:4 Changed 6 years ago by Frédéric Chapoton

Reviewers: Frédéric Chapoton

comment:5 in reply to:  3 Changed 6 years ago by Jori Mäntysalo

Status: needs_reviewpositive_review

Replying to chapoton:

You can set to positive review if you agree with my cosmetic changes.

I agree. Thanks.

comment:6 Changed 6 years ago by Volker Braun

Branch: public/212535888a667a6a29e4b00f888a38a5bedbf5a575312
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.