Opened 3 years ago

Closed 3 years ago

#21225 closed enhancement (fixed)

py3 import for cPickle (moved)

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.4
Component: python3 Keywords:
Cc: tscrim, jmantysalo, jdemeyer Merged in:
Authors: Frédéric Chapoton Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: dccec82 (Commits) Commit: dccec82bf0bac88b6eb7439ab1c8b0f5034e107d
Dependencies: Stopgaps:

Description

as another step towards python3 compatibility

Change History (9)

comment:1 Changed 3 years ago by chapoton

  • Branch set to public/21225
  • Cc tscrim jmantysalo jdemeyer added
  • Commit set to 755db275a2761b5cba9c2b21445ecb532257efa5
  • Status changed from new to needs_review

New commits:

​755db27py3 compatible imports for cPickle

comment:2 Changed 3 years ago by git

  • Commit changed from 755db275a2761b5cba9c2b21445ecb532257efa5 to ec8819a3ef440bf27ff8e052a551ac114d585520

Branch pushed to git repo; I updated commit sha1. New commits:

​ec8819atrac 21225 adding one absolute_import

comment:3 Changed 3 years ago by aapitzsch

  • Status changed from needs_review to needs_work

You probably won't include the changes to src/sage/rings/polynomial/term_order.py here?

comment:4 Changed 3 years ago by git

  • Commit changed from ec8819a3ef440bf27ff8e052a551ac114d585520 to dccec82bf0bac88b6eb7439ab1c8b0f5034e107d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​dccec82py3 compatible imports for cPickle

comment:5 Changed 3 years ago by chapoton

oops, sorry for that, doing too many things at the same time

comment:6 Changed 3 years ago by chapoton

  • Status changed from needs_work to needs_review

comment:7 Changed 3 years ago by aapitzsch

  • Reviewers set to André Apitzsch
  • Status changed from needs_review to positive_review

LGTM.

comment:8 Changed 3 years ago by chapoton

Thanks. There is a follow-up at #16069, if you have time.

comment:9 Changed 3 years ago by vbraun

  • Branch changed from public/21225 to dccec82bf0bac88b6eb7439ab1c8b0f5034e107d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.