Opened 7 years ago

Closed 6 years ago

#21225 closed enhancement (fixed)

py3 import for cPickle (moved)

Reported by: chapoton Owned by:
Priority: major Milestone: sage-7.4
Component: python3 Keywords:
Cc: tscrim, jmantysalo, jdemeyer Merged in:
Authors: Frédéric Chapoton Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: dccec82 (Commits, GitHub, GitLab) Commit: dccec82bf0bac88b6eb7439ab1c8b0f5034e107d
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Description

as another step towards python3 compatibility

Change History (9)

comment:1 Changed 7 years ago by chapoton

Branch: → public/21225
Cc: tscrim jmantysalo jdemeyer added
Commit: → 755db275a2761b5cba9c2b21445ecb532257efa5
Status: new → needs_review

New commits:

​755db27py3 compatible imports for cPickle

comment:2 Changed 7 years ago by git

Commit: 755db275a2761b5cba9c2b21445ecb532257efa5 → ec8819a3ef440bf27ff8e052a551ac114d585520

Branch pushed to git repo; I updated commit sha1. New commits:

​ec8819atrac 21225 adding one absolute_import

comment:3 Changed 7 years ago by aapitzsch

Status: needs_review → needs_work

You probably won't include the changes to src/sage/rings/polynomial/term_order.py here?

comment:4 Changed 7 years ago by git

Commit: ec8819a3ef440bf27ff8e052a551ac114d585520 → dccec82bf0bac88b6eb7439ab1c8b0f5034e107d

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​dccec82py3 compatible imports for cPickle

comment:5 Changed 7 years ago by chapoton

oops, sorry for that, doing too many things at the same time

comment:6 Changed 7 years ago by chapoton

Status: needs_work → needs_review

comment:7 Changed 7 years ago by aapitzsch

Reviewers: → André Apitzsch
Status: needs_review → positive_review

LGTM.

comment:8 Changed 7 years ago by chapoton

Thanks. There is a follow-up at #16069, if you have time.

comment:9 Changed 6 years ago by vbraun

Branch: public/21225 → dccec82bf0bac88b6eb7439ab1c8b0f5034e107d
Resolution: → fixed
Status: positive_review → closed
Note: See TracTickets for help on using tickets.