Changes between Initial Version and Version 1 of Ticket #21223


Ignore:
Timestamp:
08/11/16 12:21:02 (4 years ago)
Author:
embray
Comment:

New commits:

c80277aMake sure the WINDOWS64_ABI flag is set on Cygwin as well, otherwise the assembly routines use the wrong calling convention.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #21223

    • Property Status changed from new to needs_review
    • Property Commit changed from to c80277a2ea1663d4803e4974985f829d27d5259c
    • Property Branch changed from to u/embray/ticket-21223
    • Property Authors changed from to Erik Bray
  • Ticket #21223 – Description

    initial v1  
    11Running ECM with almost any inputs results in a segfault on Cygwin64.
    22
    3 More details soon.
     3This is because any time it enters one of its hand-written assembly routines it needs to use the appropriate calling convention (Microsoft x64 convention on Windows), but it is only picking the correct Windows calling convention when compiling with mingw.  It should do the same with Cygwin as well.
     4
     5One possible workaround without patching would be to configure ECM with `--disable-asm-redc` to disable the custom assembly code entirely.  But this is also overkill--the code works just fine as long as it's configured correctly for the platform.