Opened 5 years ago

Closed 5 years ago

#21216 closed enhancement (fixed)

direct function call to math/cmath/mpmath/numpy

Reported by: vdelecroix Owned by:
Priority: major Milestone: sage-7.4
Component: symbolics Keywords:
Cc: Merged in:
Authors: Vincent Delecroix Reviewers: Ralf Stephan
Report Upstream: N/A Work issues:
Branch: 2e87284 (Commits, GitHub, GitLab) Commit: 2e87284f6cbb5352c1130d2dbd4299cc609922b1
Dependencies: Stopgaps:

Status badges


We change the behavior of function(x) when x is one of:

  • Python float
  • Python complex
  • mpmath element
  • numpy element

In that case, the relevant function of the modules math/cmath/mpmath/numpy are used directly.

Change History (4)

comment:2 Changed 5 years ago by vdelecroix

  • Branch set to u/vdelecroix/21216
  • Commit set to 2e87284f6cbb5352c1130d2dbd4299cc609922b1
  • Status changed from new to needs_review

More or less...

New commits:

e972a7dTrac 21216: is_mpmath_type function
2e87284Trac 21216: function(x) now calls math/cmath/mpmath/numpy directly

comment:3 Changed 5 years ago by rws

  • Reviewers set to Ralf Stephan
  • Status changed from needs_review to positive_review

LGTM. Passes all tests.

comment:4 Changed 5 years ago by vbraun

  • Branch changed from u/vdelecroix/21216 to 2e87284f6cbb5352c1130d2dbd4299cc609922b1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.