Opened 6 years ago

Closed 6 years ago

#21214 closed enhancement (fixed)

bootstrap should use the autotools installed in SAGE_LOCAL/bin if available

Reported by: Matthias Köppe Owned by:
Priority: major Milestone: sage-7.4
Component: build Keywords:
Cc: Jeroen Demeyer, Vincent Delecroix, Erik Bray, Leif Leonhardy, Volker Braun, Jean-Pierre Flori, Dima Pasechnik Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 2f30faf (Commits, GitHub, GitLab) Commit: 2f30fafa0dcfebb4a74fce402a333bf9f6abd721
Dependencies: #21047 Stopgaps:

Status badges

Description (last modified by Matthias Köppe)

... this is so that it does not have to rely on downloading the generated files, nor on an external installation of the autotools (which is convenient on Mac OS X because one has to remove fink from PATH).

This patch sources src/bin/sage-env in order to augment PATH just before calling the autotools.

Change History (9)

comment:1 Changed 6 years ago by Matthias Köppe

Branch: u/mkoeppe/bootstrap_should_use_the_autotools_installed_in_sage_local_bin_if_available

comment:2 Changed 6 years ago by Matthias Köppe

Authors: Matthias Koeppe
Cc: Jeroen Demeyer Vincent Delecroix Erik Bray Leif Leonhardy Volker Braun Jean-Pierre Flori added
Commit: 2f30fafa0dcfebb4a74fce402a333bf9f6abd721
Description: modified (diff)
Milestone: sage-7.4
Status: newneeds_review

New commits:

2f30fafbootstrap: Get autotools from our own package into PATH

comment:3 Changed 6 years ago by Matthias Köppe

Cc: Dima Pasechnik added

comment:4 Changed 6 years ago by Dima Pasechnik

src/bin/ != SAGE_LOCAL/bin/; thus either the branch or the ticket description is wrong.

Last edited 6 years ago by Dima Pasechnik (previous) (diff)

comment:5 Changed 6 years ago by Matthias Köppe

Description: modified (diff)

comment:6 Changed 6 years ago by Dima Pasechnik

the title still says "bootstrap should use the autotools installed in SAGE_LOCAL/bin if available".

comment:7 in reply to:  6 Changed 6 years ago by Leif Leonhardy

Replying to dimpase:

the title still says "bootstrap should use the autotools installed in SAGE_LOCAL/bin if available".

... which is correct.

comment:8 Changed 6 years ago by Dima Pasechnik

Reviewers: Dima Pasechnik
Status: needs_reviewpositive_review

ok, good, sorry for confusion.

comment:9 Changed 6 years ago by Volker Braun

Branch: u/mkoeppe/bootstrap_should_use_the_autotools_installed_in_sage_local_bin_if_available2f30fafa0dcfebb4a74fce402a333bf9f6abd721
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.