Opened 4 years ago

Closed 4 years ago

#21214 closed enhancement (fixed)

bootstrap should use the autotools installed in SAGE_LOCAL/bin if available

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-7.4
Component: build Keywords:
Cc: jdemeyer, vdelecroix, embray, leif, vbraun, jpflori, dimpase Merged in:
Authors: Matthias Koeppe Reviewers: Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: 2f30faf (Commits) Commit: 2f30fafa0dcfebb4a74fce402a333bf9f6abd721
Dependencies: #21047 Stopgaps:

Description (last modified by mkoeppe)

... this is so that it does not have to rely on downloading the generated files, nor on an external installation of the autotools (which is convenient on Mac OS X because one has to remove fink from PATH).

This patch sources src/bin/sage-env in order to augment PATH just before calling the autotools.

Change History (9)

comment:1 Changed 4 years ago by mkoeppe

  • Branch set to u/mkoeppe/bootstrap_should_use_the_autotools_installed_in_sage_local_bin_if_available

comment:2 Changed 4 years ago by mkoeppe

  • Authors set to Matthias Koeppe
  • Cc jdemeyer vdelecroix embray leif vbraun jpflori added
  • Commit set to 2f30fafa0dcfebb4a74fce402a333bf9f6abd721
  • Description modified (diff)
  • Milestone set to sage-7.4
  • Status changed from new to needs_review

New commits:

2f30fafbootstrap: Get autotools from our own package into PATH

comment:3 Changed 4 years ago by mkoeppe

  • Cc dimpase added

comment:4 Changed 4 years ago by dimpase

src/bin/ != SAGE_LOCAL/bin/; thus either the branch or the ticket description is wrong.

Last edited 4 years ago by dimpase (previous) (diff)

comment:5 Changed 4 years ago by mkoeppe

  • Description modified (diff)

comment:6 follow-up: Changed 4 years ago by dimpase

the title still says "bootstrap should use the autotools installed in SAGE_LOCAL/bin if available".

comment:7 in reply to: ↑ 6 Changed 4 years ago by leif

Replying to dimpase:

the title still says "bootstrap should use the autotools installed in SAGE_LOCAL/bin if available".

... which is correct.

comment:8 Changed 4 years ago by dimpase

  • Reviewers set to Dima Pasechnik
  • Status changed from needs_review to positive_review

ok, good, sorry for confusion.

comment:9 Changed 4 years ago by vbraun

  • Branch changed from u/mkoeppe/bootstrap_should_use_the_autotools_installed_in_sage_local_bin_if_available to 2f30fafa0dcfebb4a74fce402a333bf9f6abd721
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.