Opened 11 years ago

Closed 5 years ago

Last modified 3 years ago

#2120 closed defect (duplicate)

Maple interface completely broken with Maple 11

Reported by: was Owned by: was
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: interfaces Keywords:
Cc: Merged in:
Authors: Reviewers: Ralf Stephan
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by chapoton)

This is what we get for not running the optional doctests. Maple 10 still works fine. With Maple 11 the Sage interface is completely totally broken:

sage -t --only-optional=maple devel/sage/sage/symbolic/expression.pyx # 2 doctests failed
sage -t --only-optional=maple devel/sage/sage/symbolic/integration/integral.py # 2 doctests failed
sage -t --only-optional=maple devel/sage/sage/calculus/calculus.py # 1 doctests failed
sage -t --only-optional=maple devel/sage/sage/misc/functional.py # 1 doctests failed
sage -t --only-optional=maple devel/sage/sage/tests/benchmark.py # 5 doctests failed
sage -t --only-optional=maple devel/sage/sage/interfaces/maple.py # 123 doctests failed

Attachments (2)

trac-2120-maple_interface.patch (7.6 KB) - added by was 11 years ago.
trac-2120-maple_interface-2.patch (6.1 KB) - added by ncalexan 10 years ago.

Download all attachments as: .zip

Change History (24)

comment:1 Changed 11 years ago by was

  • Status changed from new to assigned

Changed 11 years ago by was

comment:2 Changed 11 years ago by was

  • Summary changed from maple -- the interface is completely broken in Sage-2.10.1 with Maple 11. to [with patch; not ready for review] maple -- the interface is completely broken in Sage-2.10.1 with Maple 11.

The attached patch trac-2120-maple_interface.patch completely fixes all these problems on Maple with OS X. It may partly break things on Linux, maybe. (?) I don't have a good net connection with access to Linux Maple right now for testing, but will someday and then post a followup patch that fixes any issues.

NOTE: This patch *vastly* improves the robustness of the Maple interface, to put it mildly.

comment:3 Changed 11 years ago by craigcitro

  • Keywords editor_craigcitro added

comment:4 Changed 11 years ago by mhansen

I'll take care of this.

comment:5 Changed 10 years ago by was

With stock Maple 12 and stock sage-3.3.alpha0 on OS X, here's what happens (total disaster):

teragon-2:graphics wstein$ ~/build/sage-3.3.alpha0/sage
----------------------------------------------------------------------
| Sage Version 3.3.alpha0, Release Date: 2009-01-19                  |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------
sage: maple('2+2')

sage: maple('2+2')
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)

/Users/wstein/.sage/temp/teragon_2.local/96783/_Users_wstein__sage_init_sage_0.py in <module>()
----> 1 
      2 
      3 
      4 
      5 

/Users/wstein/build/sage-3.3.alpha0/local/lib/python2.5/site-packages/sage/interfaces/expect.pyc in __call__(self, x, name)
    963             return x
    964         if isinstance(x, basestring):
--> 965             return cls(self, x, name=name)
    966         try:
    967             return self._coerce_from_special_method(x)

/Users/wstein/build/sage-3.3.alpha0/local/lib/python2.5/site-packages/sage/interfaces/expect.pyc in __init__(self, parent, value, is_name, name)
   1333             except (TypeError, KeyboardInterrupt, RuntimeError, ValueError), x:
   1334                 self._session_number = -1
-> 1335                 raise TypeError, x
   1336         self._session_number = parent._session_number
   1337 

TypeError: An error occured running a Maple command:
INPUT:
read "/Users/wstein/.sage//temp/teragon_2.local/96783//interface//tmp96783";
OUTPUT:
read "/Users/wstein/.sage//temp/teragon_2.local/96783//interface//tmp96783";
on line 2, syntax error, `)` unexpected:
age0);
    ^
Error, while reading
`/Users/wstein/.sage//temp/teragon_2.local/96783//interface//tmp96783`

comment:6 Changed 10 years ago by was

I tried today, and

  • maple 12 works fine on OS X (for me). Perfect in fact.
  • maple 12 on linux, fails totally:
    wstein@sage:~$ sage
    ----------------------------------------------------------------------
    | Sage Version 3.2.3, Release Date: 2009-01-05                       |
    | Type notebook() for the GUI, and license() for information.        |
    ----------------------------------------------------------------------
    sage: maple('2+3')
    
    sage: maple('2+3')
    read "/scratch/wstein/sage//temp/sage.math.washington.edu/1285//interface/
    

comment:7 Changed 10 years ago by was

the poor attached patch:

Hunk #1 FAILED at 859
Hunk #2 succeeded at 1496 with fuzz 2 (offset 382 lines).
1 out of 2 hunks FAILED -- saving rejects to file sage/interfaces/expect.py.rej
patching file sage/interfaces/maple.py
Hunk #3 FAILED at 245
Hunk #4 FAILED at 390
Hunk #5 FAILED at 442
Hunk #6 FAILED at 606
4 out of 7 hunks FAILED -- saving rejects to file sage/interfaces/maple.py.rej

Changed 10 years ago by ncalexan

comment:8 Changed 10 years ago by ncalexan

  • Summary changed from [with patch; not ready for review] maple -- the interface is completely broken in Sage-2.10.1 with Maple 11. to [with patch, needs review] maple -- the interface is completely broken in Sage-2.10.1 with Maple 11.

The second patch rebases the *much* earlier patch. It makes doctests and the command line work for me on sage.math, but not having maple I need testers on consumer linux distros and especially Mac OS X.

comment:9 Changed 10 years ago by was

  • Summary changed from [with patch, needs review] maple -- the interface is completely broken in Sage-2.10.1 with Maple 11. to [with patch, needs work] maple -- the interface is completely broken in Sage-2.10.1 with Maple 11.

It hangs forever on using it with Maple 12 on my Mac laptop:

sage: maple('2+3')
[hang forever]

I'll install Maple 12 on my beefy office desktop OS X box (bsd.math.washington.edu), and give you an account.

comment:10 Changed 10 years ago by was

By the way, the code *currently* in sage-3.4 works fine with Maple 12 on OS X on my laptop. So the patch breaks things for OS X.

comment:11 Changed 10 years ago by malb

Here is what I currently get with Maple 11:

sage -t --optional "devel/sage-main/sage/interfaces/maple.py"            
**********************************************************************   
File "/usr/local/sage-4.1/devel/sage-main/sage/interfaces/maple.py", line 29:
    sage: maple.eval('ifactor(2005)')                    # optional - maple  
Expected:                                                                    
    '"(5)*"(401)'                                                            
Got:                                                                         
    '``(5)*``(401)'                                                          
**********************************************************************       
File "/usr/local/sage-4.1/devel/sage-main/sage/interfaces/maple.py", line 31:
    sage: maple.ifactor(2005)                            # optional - maple  
Expected:                                                                    
    "(5)*"(401)                                                              
Got:                                                                         
    ``(5)*``(401)                                                            
**********************************************************************       
File "/usr/local/sage-4.1/devel/sage-main/sage/interfaces/maple.py", line 188:
    sage: maple.ifactor(maple.fibonacci(27))     # optional - maple
Expected:
    "(2)*"(17)*"(53)*"(109)
Got:
    ``(2)*``(17)*``(53)*``(109)
**********************************************************************
File "/usr/local/sage-4.1/devel/sage-main/sage/interfaces/maple.py", line 1068:
    sage: print latex(maple(pi - e^3))                   # optional -- requires maple
Expected:
    \pi - \left( {e^{1}} \right) ^{3}
Got:
    \pi-{e^{3}}
**********************************************************************
2 items had failures:
   3 of  28 in __main__.example_0
   1 of   4 in __main__.example_40
***Test Failed*** 4 failures.
For whitespace errors, see the file /usr/local/sage-4.1/tmp/.doctest_maple.py
         [21.0 s]

comment:12 Changed 8 years ago by abbot

  • Report Upstream set to N/A

I have tested this patch on Linux/x86_64 (Fedora 14) with sage-4.4.1 and Maple 13, and also Maple 11. It does fix the problem. Test output with Maple 13:

sage -t --optional "devel/sage-main/sage/interfaces/maple.py"
**********************************************************************
File "/opt/sage-4.4.1/devel/sage-main/sage/interfaces/maple.py", line 1013:
    sage: u == t                                   # optional -- requires maple
Expected:
    True
Got:
    False
**********************************************************************
File "/opt/sage-4.4.1/devel/sage-main/sage/interfaces/maple.py", line 1118:
    sage: print latex(maple(pi - e^3))                   # optional -- requires maple
Expected:
    \pi - \left( {e^{1}} \right) ^{3}
Got:
    \pi-{{\rm e}^{3}}
**********************************************************************
2 items had failures:
   1 of  22 in __main__.example_36
   1 of   4 in __main__.example_40
***Test Failed*** 2 failures.
For whitespace errors, see the file /home/shamardin/.sage//tmp/.doctest_maple.py
	 [39.6 s]
 
----------------------------------------------------------------------
The following tests failed:


	sage -t --optional "devel/sage-main/sage/interfaces/maple.py"
Total time for all tests: 39.6 seconds

comment:13 Changed 6 years ago by robertwb

As of sage 5.5

	sage -t --only-optional=maple devel/sage/sage/symbolic/expression.pyx # 2 doctests failed
	sage -t --only-optional=maple devel/sage/sage/symbolic/integration/integral.py # 2 doctests failed
	sage -t --only-optional=maple devel/sage/sage/calculus/calculus.py # 1 doctests failed
	sage -t --only-optional=maple devel/sage/sage/misc/functional.py # 1 doctests failed
	sage -t --only-optional=maple devel/sage/sage/tests/benchmark.py # 5 doctests failed
	sage -t --only-optional=maple devel/sage/sage/interfaces/maple.py # 123 doctests failed

Related: #13540

comment:14 Changed 6 years ago by jdemeyer

  • Description modified (diff)
  • Keywords editor_craigcitro removed
  • Summary changed from [with patch, needs work] maple -- the interface is completely broken in Sage-2.10.1 with Maple 11. to Maple interface completely broken with Maple 11

comment:15 Changed 6 years ago by migeruhito

See Ticket #12295

comment:16 Changed 6 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:17 Changed 5 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:18 Changed 5 years ago by mmezzarobba

  • Milestone changed from sage-6.2 to sage-duplicate/invalid/wontfix
  • Status changed from needs_work to needs_review

close in favor of #12295, which is more up to date?

comment:19 Changed 5 years ago by rws

  • Status changed from needs_review to positive_review

Yes, since there is apparently a fix attached for sage-5.9, while the last comment here concerns 5.5.

comment:20 Changed 5 years ago by rws

  • Reviewers set to Ralf Stephan

comment:21 Changed 5 years ago by vbraun

  • Resolution set to duplicate
  • Status changed from positive_review to closed

comment:22 Changed 3 years ago by chapoton

  • Description modified (diff)
Note: See TracTickets for help on using tickets.